Skip to content

Don't send pings if upload is disabled#575

Merged
badboy merged 2 commits into
masterfrom
regression-dont-upload
Dec 16, 2019
Merged

Don't send pings if upload is disabled#575
badboy merged 2 commits into
masterfrom
regression-dont-upload

Conversation

@badboy
Copy link
Copy Markdown
Member

@badboy badboy commented Dec 13, 2019

No description provided.

Comment thread glean-core/src/lib.rs
@badboy badboy requested a review from Dexterp37 December 13, 2019 14:02
Copy link
Copy Markdown
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @chutten for finding this!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 13, 2019

Codecov Report

Merging #575 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #575      +/-   ##
============================================
- Coverage     74.91%   74.87%   -0.04%     
  Complexity      334      334              
============================================
  Files           101      101              
  Lines          5915     5918       +3     
  Branches        739      741       +2     
============================================
  Hits           4431     4431              
- Misses          944      945       +1     
- Partials        540      542       +2
Impacted Files Coverage Δ Complexity Δ
glean-core/src/lib.rs 62.18% <66.66%> (+0.06%) 0 <0> (ø) ⬇️
glean-core/src/metrics/datetime.rs 40.38% <0%> (-3.85%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03562ec...8bf4863. Read the comment docs.

@badboy badboy merged commit 30683e4 into master Dec 16, 2019
@badboy badboy deleted the regression-dont-upload branch December 16, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants