Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Jan 6, 2020

A couple of complications beyond the usual here:

I merged the v22.1.0 tag into master -- I don't think this was done earlier, and it fixes the changelog which previously didn't have an entry for that version.

Updated the prepare_release.sh script to update the version in glean-preview.

notification_emails:
- glean-team@mozilla.com
expires: never
- all_pings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should not be there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Bad merge.

@mdboom
Copy link
Contributor Author

mdboom commented Jan 6, 2020

Let's hold off on merging this until #609 is resolved, which @Dexterp37 can comment on when he gets back.

@mdboom mdboom changed the title Release 23.0.0 WIP: Release 23.0.0 Jan 6, 2020
@Dexterp37
Copy link
Contributor

Let's hold off on merging this until #609 is resolved, which @Dexterp37 can comment on when he gets back.

Thanks for putting this together. I'm fine with cutting a release and I've approved #609

@Dexterp37
Copy link
Contributor

I merged the v22.1.0 tag into master -- I don't think this was done earlier, and it fixes the changelog which previously didn't have an entry for that version.

@mdboom , is there a missing step in the docs?

@mdboom mdboom changed the title WIP: Release 23.0.0 Release 23.0.0 Jan 7, 2020
@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #615 into master will decrease coverage by 13.71%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #615       +/-   ##
=============================================
- Coverage     87.55%   73.84%   -13.72%     
+ Complexity      336      334        -2     
=============================================
  Files            64      103       +39     
  Lines          3030     6198     +3168     
  Branches        168      785      +617     
=============================================
+ Hits           2653     4577     +1924     
- Misses          291     1048      +757     
- Partials         86      573      +487
Impacted Files Coverage Δ Complexity Δ
...va/mozilla/telemetry/glean/config/Configuration.kt 95.23% <0%> (-0.77%) 7% <0%> (-2%)
glean-core/src/metrics/timespan.rs 72.83% <0%> (ø) 0% <0%> (?)
glean-core/src/storage/mod.rs 89.61% <0%> (ø) 0% <0%> (?)
glean-core/preview/src/core_metrics.rs 0% <0%> (ø) 0% <0%> (?)
glean-core/src/metrics/experiment.rs 78.07% <0%> (ø) 0% <0%> (?)
glean-core/src/metrics/quantity.rs 75.75% <0%> (ø) 0% <0%> (?)
glean-core/src/database/mod.rs 62.54% <0%> (ø) 0% <0%> (?)
glean-core/src/metrics/custom_distribution.rs 72.83% <0%> (ø) 0% <0%> (?)
glean-core/src/metrics/datetime.rs 40.38% <0%> (ø) 0% <0%> (?)
glean-core/src/metrics/counter.rs 89.18% <0%> (ø) 0% <0%> (?)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca33526...def17a1. Read the comment docs.

@mdboom mdboom merged commit 49a9732 into mozilla:master Jan 7, 2020
@mdboom
Copy link
Contributor Author

mdboom commented Jan 7, 2020

I merged the v22.1.0 tag into master -- I don't think this was done earlier, and it fixes the changelog which previously didn't have an entry for that version.

@mdboom , is there a missing step in the docs?

As best I can tell, I think this release was tagged from a branch that wasn't on master. Perhaps the missing step to document is that when you do this, you should merge that branch back into master (which is what I did to put this PR together).

@mdboom mdboom deleted the release-23.0.0 branch April 14, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants