-
Notifications
You must be signed in to change notification settings - Fork 155
Release 23.0.0 #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 23.0.0 #615
Conversation
glean-core/metrics.yaml
Outdated
| notification_emails: | ||
| - glean-team@mozilla.com | ||
| expires: never | ||
| - all_pings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Bad merge.
|
Let's hold off on merging this until #609 is resolved, which @Dexterp37 can comment on when he gets back. |
Thanks for putting this together. I'm fine with cutting a release and I've approved #609 |
@mdboom , is there a missing step in the docs? |
Fixup the missing 'v' in the version compare URL Co-Authored-By: Jan-Erik Rediger <badboy@archlinux.us>
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=============================================
- Coverage 87.55% 73.84% -13.72%
+ Complexity 336 334 -2
=============================================
Files 64 103 +39
Lines 3030 6198 +3168
Branches 168 785 +617
=============================================
+ Hits 2653 4577 +1924
- Misses 291 1048 +757
- Partials 86 573 +487
Continue to review full report at Codecov.
|
As best I can tell, I think this release was tagged from a branch that wasn't on master. Perhaps the missing step to document is that when you do this, you should merge that branch back into master (which is what I did to put this PR together). |
A couple of complications beyond the usual here:
I merged the
v22.1.0tag into master -- I don't think this was done earlier, and it fixes the changelog which previously didn't have an entry for that version.Updated the
prepare_release.shscript to update the version inglean-preview.