Skip to content

MAINT: Fix Python checking#859

Merged
mdboom merged 1 commit intomozilla:masterfrom
mdboom:rename-subprocess
May 7, 2020
Merged

MAINT: Fix Python checking#859
mdboom merged 1 commit intomozilla:masterfrom
mdboom:rename-subprocess

Conversation

@mdboom
Copy link
Copy Markdown
Contributor

@mdboom mdboom commented May 5, 2020

This fixes issues with real-time automatic syntax and type checking in VSCode and Emacs (flycheck).

  • Having a module named subprocess caused mypy to get confused between it and the stdlib subprocess module.
  • Flycheck uses .flake8rc, contrary to VSCode and the flake8 tool itself which uses .flake8. Including a symlink to fix this up.

@auto-assign auto-assign Bot requested a review from Dexterp37 May 5, 2020 18:07
@mdboom mdboom force-pushed the rename-subprocess branch from 2f5cbdf to cb8fa84 Compare May 7, 2020 13:12
@mdboom mdboom merged commit 1850ad1 into mozilla:master May 7, 2020
@mdboom mdboom deleted the rename-subprocess branch May 7, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants