fix(go_server): Serialize nil string_list metrics as empty arrays instead of null#837
Merged
fix(go_server): Serialize nil string_list metrics as empty arrays instead of null#837
Conversation
…tead of null Go nil slices serialize to JSON null which fails Glean schema validation (expected JSONArray). Add nil-coalescing in generated Record functions so omitted string_list fields produce [] instead of null.
efixler
approved these changes
Mar 17, 2026
dmueller
approved these changes
Mar 17, 2026
travis79
approved these changes
Mar 17, 2026
Member
travis79
left a comment
travis79
left a comment
There was a problem hiding this comment.
Please add a brief CHANGELOG.md entry for this, to help document the fix and r+ from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go nil slices serialize to JSON null which fails Glean schema validation (expected JSONArray). Add nil-coalescing in generated Record functions so omitted string_list fields produce [] instead of null.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one