This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 1205667 - get_tidied_content can return blank#3497
Merged
Conversation
kuma/wiki/models.py
Outdated
Contributor
There was a problem hiding this comment.
I'm worried that an empty string is a valid tidied content. I'd rather return something non-string, like None (changing param to allow_null or async), to specify that no content was returned.
Contributor
|
Oh, and test coverage 😄 |
groovecoder
force-pushed
the
never-tidy-in-compare-request-1205667
branch
from
def1695 to
8c546d9
Compare
When a $compare request is made for a large revision, we want to skip tidy_content and return a warning to the user, so we don't block requests on the expensive tidy operation.
Contributor
Author
|
Updated with changes and tests. |
Contributor
|
+r was able to get the "Server is rendering the content comparison. Please refresh this page in a few minutes." message, refreshed and got it again, and on third refresh got the content comparison. |
jwhitlock
added a commit
that referenced
this pull request
Sep 18, 2015
…205667 bug 1205667 - get_tidied_content can return blank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a $compare request is made for a large revision,
we want to skip tidy_content and return a warning to the user,
so we don't block requests on the expensive tidy operation.