This repository was archived by the owner on Aug 26, 2022. It is now read-only.
Merged
Conversation
apps/wiki/tests/test_content.py
Outdated
Contributor
There was a problem hiding this comment.
jinja2.escape is probably faster unless you need some behavior from sax.
Contributor
|
test and spot-check pass. rebase, pep8 cleanup and jinja2.escape change (if you want to) r+ |
Contributor
Author
|
Rebased and did some code cleanup for pep8, but didn't address all the warnings. There's a lot to be done there, unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do merge this, if it seems good.
Going to try something different here: This PR consists of a series of commits, each a discrete change that should almost stand on its own and not break the site. Altogether, the PR implements most of a feature, but there are a few things left to wrap up.
What you should be able to spot-check on a dev VM, though, is this:
Add some code listings inside a container div (in source view, because there's no good editor yet), something like this:
Take the URL of the page, add
$samples/sample2, eg:https://developer-local.allizom.org/en-US/docs/User:lmorchard/TestCodeSamples$samples/s2
Upon visiting that URL, you should see the results of the code sample as a live page