Use TaskclusterConfig from official library#15
Merged
La0 merged 3 commits intomozilla:masterfrom Dec 3, 2019
Merged
Conversation
Contributor
La0
commented
Nov 21, 2019
La0
commented
marco-c
reviewed
Dec 3, 2019
| assert isinstance(period, int) | ||
| def __init__( | ||
| self, | ||
| taskcluster_config: TaskclusterConfig, |
marco-c
reviewed
Dec 3, 2019
| pytoml | ||
| structlog | ||
| taskcluster | ||
| taskcluster==24.0.0 |
Collaborator
There was a problem hiding this comment.
Can we do >=? Or not specify it at all?
Contributor
Author
There was a problem hiding this comment.
I prefer to explicitly set the min version, will switch to >=
marco-c
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.