Skip to content

Simplify EphemeralStorage, make it work across separate workers#50

Merged
marco-c merged 2 commits intomozilla:masterfrom
marco-c:ephemeral_storage_changes
Jan 8, 2020
Merged

Simplify EphemeralStorage, make it work across separate workers#50
marco-c merged 2 commits intomozilla:masterfrom
marco-c:ephemeral_storage_changes

Conversation

@marco-c
Copy link
Copy Markdown
Collaborator

@marco-c marco-c commented Jan 8, 2020

With the previous implementation, since the cache was in local memory, separate workers could not access to the same values.

@marco-c marco-c requested a review from La0 January 8, 2020 11:09
Copy link
Copy Markdown
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way simpler indeed.
Ok for me if the tests with Redis in CI are ok (i rebased it after merging #43 )

Comment thread libmozevent/storage.py
@marco-c marco-c merged commit 851001f into mozilla:master Jan 8, 2020
@marco-c marco-c deleted the ephemeral_storage_changes branch January 8, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants