Skip to content

chore: skip artifact generation for thunderbird_crashreporter#1428

Merged
mikewilli merged 1 commit intomainfrom
disallow-thunderbird-crashreporter
Apr 8, 2026
Merged

chore: skip artifact generation for thunderbird_crashreporter#1428
mikewilli merged 1 commit intomainfrom
disallow-thunderbird-crashreporter

Conversation

@mikewilli
Copy link
Copy Markdown
Contributor

No description provided.

@mikewilli mikewilli added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 016a79f Apr 8, 2026
17 checks passed
@mikewilli mikewilli deleted the disallow-thunderbird-crashreporter branch April 8, 2026 20:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Integration report for "this commit"

lookml.diff

Click to expand!
Only in /tmp/workspace/looker-hub/firefox_ios: dashboards
Only in /tmp/workspace/looker-hub/marketing: datagroups
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_data_validation_reports_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/search_private/datagroups: search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
Only in /tmp/workspace/looker-hub/: user_journey
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/fenix/views/metrics.view.lkml /tmp/workspace/generated-lookml/fenix/views/metrics.view.lkml
--- /tmp/workspace/looker-hub/fenix/views/metrics.view.lkml	2026-04-08 20:14:53.943270764 +0000
+++ /tmp/workspace/generated-lookml/fenix/views/metrics.view.lkml	2026-04-08 20:14:48.914095734 +0000
@@ -2120,7 +2120,7 @@
 
   dimension: metrics__timing_distribution__perf_awesomebar_shortcuts_suggestions__sum {
     label: "Perf Awesomebar: Shortcuts Suggestions Sum"
-    hidden: no
+    hidden: yes
     sql: ${TABLE}.metrics.timing_distribution.perf_awesomebar_shortcuts_suggestions.sum ;;
     type: number
     group_label: "Perf Awesomebar"
@@ -2837,7 +2837,7 @@
 
   dimension: metrics__boolean__preferences_search_shortcuts_enabled {
     label: "Preferences: Search Shortcuts Enabled"
-    hidden: no
+    hidden: yes
     sql: ${TABLE}.metrics.boolean.preferences_search_shortcuts_enabled ;;
     type: yesno
     group_label: "Preferences"
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/fenix/views/metrics_table.view.lkml /tmp/workspace/generated-lookml/fenix/views/metrics_table.view.lkml
--- /tmp/workspace/looker-hub/fenix/views/metrics_table.view.lkml	2026-04-08 20:14:53.944149496 +0000
+++ /tmp/workspace/generated-lookml/fenix/views/metrics_table.view.lkml	2026-04-08 20:14:48.932095681 +0000
@@ -13553,7 +13553,7 @@
   dimension: metrics__labeled_counter__media_audio_init_failure {
     sql: ${TABLE}.metrics.labeled_counter.media_audio_init_failure ;;
     hidden: yes
-    description: "Failure occurs when initializing the audio stream.
+    description: "Failure occurs when initializing the audio stream. (Migrated from the geckoview metric of the same name).
 "
   }
 
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/firefox_desktop/views/events_stream.view.lkml /tmp/workspace/generated-lookml/firefox_desktop/views/events_stream.view.lkml
--- /tmp/workspace/looker-hub/firefox_desktop/views/events_stream.view.lkml	2026-04-08 20:14:53.954476816 +0000
+++ /tmp/workspace/generated-lookml/firefox_desktop/views/events_stream.view.lkml	2026-04-08 20:14:49.081095241 +0000
@@ -6339,6 +6339,14 @@
     group_item_label: "Window"
   }
 
+  dimension: extras__string__window_mode {
+    sql: ${TABLE}.extras.string.window_mode ;;
+    type: string
+    suggest_persist_for: "24 hours"
+    group_label: "Extras: String"
+    group_item_label: "Window Mode"
+  }
+
   dimension: is_bot_generated {
     sql: ${TABLE}.is_bot_generated ;;
     type: yesno
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/firefox_desktop/views/metrics_table.view.lkml /tmp/workspace/generated-lookml/firefox_desktop/views/metrics_table.view.lkml
--- /tmp/workspace/looker-hub/firefox_desktop/views/metrics_table.view.lkml	2026-04-08 20:14:53.959149451 +0000
+++ /tmp/workspace/generated-lookml/firefox_desktop/views/metrics_table.view.lkml	2026-04-08 20:14:49.162095002 +0000
@@ -18726,9 +18726,8 @@
   dimension: metrics__labeled_timing_distribution__search_suggestions_latency {
     sql: ${TABLE}.metrics.labeled_timing_distribution.search_suggestions_latency ;;
     hidden: yes
-    description: "Records the latencies (ms) of search suggestions fetches per search engine. Keys in this histogram are the search engine identifier for configuration provided search engines and 'other' for search engines installed via other methods.
+    description: "Records the latencies (ms) of search suggestions fetches per search engine. Keys in this histogram are search engine identifiers for built-in search engines and 'other' for non-built-in search engines.
 This metric was generated to correspond to the Legacy Telemetry exponential histogram SEARCH_SUGGESTIONS_LATENCY_MS.
-This metric was renamed in Gecko 144 from `search.suggestions_latency` and changed to report the search engine identifier rather than the telemetry identifier.
 "
   }
 
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	2026-04-08 20:14:53.970707125 +0000
+++ /tmp/workspace/generated-lookml/marketing/datagroups/firefox_for_families_forecasted_expectations_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: firefox_for_families_forecasted_expectations_last_updated {
-  label: "firefox_for_families_forecasted_expectations Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `mozdata`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'analysis' AND table_name = 'marketing_firefox_for_families_forecasted_expectations')
-
-    ) ;;
-  description: "Updates for firefox_for_families_forecasted_expectations when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/monitoring/datagroups/event_monitoring_live_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/monitoring/datagroups/event_monitoring_live_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/monitoring/datagroups/event_monitoring_live_last_updated.datagroup.lkml	2026-04-08 20:14:53.972463477 +0000
+++ /tmp/workspace/generated-lookml/monitoring/datagroups/event_monitoring_live_last_updated.datagroup.lkml	2026-04-08 20:14:49.333094498 +0000
@@ -208,6 +208,10 @@
  UNION ALL 
     SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
     FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
+    WHERE (table_schema = 'thunderbird_crashreporter_derived' AND table_name = 'event_monitoring_live_v1')
+ UNION ALL 
+    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
+    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
     WHERE (table_schema = 'thunderbird_desktop_derived' AND table_name = 'event_monitoring_live_v1')
 
     ) ;;
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/monitoring/views/bigeye_usage.view.lkml /tmp/workspace/generated-lookml/monitoring/views/bigeye_usage.view.lkml
--- /tmp/workspace/looker-hub/monitoring/views/bigeye_usage.view.lkml	2026-04-08 20:14:53.973331352 +0000
+++ /tmp/workspace/generated-lookml/monitoring/views/bigeye_usage.view.lkml	2026-04-08 20:14:49.333094498 +0000
@@ -15,34 +15,29 @@
     sql: ${TABLE}.job_id ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "ID of job"
   }
 
   dimension: labels {
     sql: ${TABLE}.labels ;;
     hidden: yes
-    description: "Array of labels applied to the job as key-value pairs."
   }
 
   dimension: reference_dataset_id {
     sql: ${TABLE}.reference_dataset_id ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "The ID of the dataset referenced by the job"
   }
 
   dimension: reference_project_id {
     sql: ${TABLE}.reference_project_id ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "The ID of the project referenced by the job"
   }
 
   dimension: reference_table_id {
     sql: ${TABLE}.reference_table_id ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "The ID of the table referenced by the job"
   }
 
   dimension: service_account {
@@ -54,7 +49,6 @@
   dimension: task_duration {
     sql: ${TABLE}.task_duration ;;
     hidden: yes
-    description: "The time it took to run the job"
   }
 
   dimension: task_duration_seconds {
@@ -67,21 +61,18 @@
     sql: ${TABLE}.total_slot_ms ;;
     type: number
     suggest_persist_for: "24 hours"
-    description: "Slot milliseconds for the job over its entire duration"
   }
 
   dimension: total_terabytes_billed {
     sql: ${TABLE}.total_terabytes_billed ;;
     type: number
     suggest_persist_for: "24 hours"
-    description: "Total terabytes billed by the job if on-demand pricing is used"
   }
 
   dimension: total_terabytes_processed {
     sql: ${TABLE}.total_terabytes_processed ;;
     type: number
     suggest_persist_for: "24 hours"
-    description: "Total terabytes processed by the job"
   }
 
   dimension_group: creation {
@@ -97,7 +88,6 @@
     ]
     convert_tz: no
     datatype: date
-    description: "Job creation date"
   }
 
   dimension_group: submission {
@@ -113,7 +103,6 @@
     ]
     convert_tz: no
     datatype: date
-    description: "Date Airflow DAG is executed, and partition date"
   }
 
   measure: cost_sum {
@@ -149,13 +138,11 @@
     sql: ${TABLE}.key ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "Label key."
   }
 
   dimension: value {
     sql: ${TABLE}.value ;;
     type: string
     suggest_persist_for: "24 hours"
-    description: "Label value."
   }
 }
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	2026-04-08 20:14:53.997973610 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_data_validation_reports_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_data_validation_reports_last_updated {
-  label: "search_term_data_validation_reports Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'search_term_data_validation_reports_v1')
-
-    ) ;;
-  description: "Updates for search_term_data_validation_reports when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml
--- /tmp/workspace/looker-hub/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	2026-04-08 20:14:53.997987113 +0000
+++ /tmp/workspace/generated-lookml/search_private/datagroups/search_term_sanitization_job_metadata_daily_last_updated.datagroup.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,20 +0,0 @@
-# *Do not manually modify this file*
-
-# This file has been generated via https://github.com/mozilla/lookml-generator
-
-# Using a datagroup in an Explore: https://cloud.google.com/looker/docs/reference/param-explore-persist-with
-# Using a datagroup in a derived table: https://cloud.google.com/looker/docs/reference/param-view-datagroup-trigger
-
-datagroup: search_term_sanitization_job_metadata_daily_last_updated {
-  label: "search_term_sanitization_job_metadata_daily Last Updated"
-  sql_trigger: SELECT MAX(storage_last_modified_time)
-    FROM (
-        
-    SELECT MAX(storage_last_modified_time) AS storage_last_modified_time
-    FROM `moz-fx-data-shared-prod`.`region-us`.INFORMATION_SCHEMA.TABLE_STORAGE
-    WHERE (table_schema = 'search_terms_derived' AND table_name = 'sanitization_job_metadata_v2')
-
-    ) ;;
-  description: "Updates for search_term_sanitization_job_metadata_daily when referenced tables are modified."
-  max_cache_age: "24 hours"
-}
\ No newline at end of file
diff -x '.*' -bur --no-dereference --new-file /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml
--- /tmp/workspace/looker-hub/user_journey/views/events_daily.view.lkml	2026-04-08 20:14:53.999979566 +0000
+++ /tmp/workspace/generated-lookml/user_journey/views/events_daily.view.lkml	1970-01-01 00:00:00.000000000 +0000
@@ -1,71 +0,0 @@
-view: events_daily {
-  sql_table_name: `mozdata.messaging_system.events_daily`
-    ;;
-
-  dimension: addon_version {
-    type: string
-    sql: ${TABLE}.addon_version ;;
-  }
-
-  dimension: app_version {
-    type: string
-    sql: ${TABLE}.app_version ;;
-  }
-
-  dimension: city {
-    type: string
-    sql: ${TABLE}.city ;;
-  }
-
-  dimension: client_id {
-    type: string
-    sql: ${TABLE}.client_id ;;
-  }
-
-  dimension: country {
-    type: string
-    map_layer_name: countries
-    sql: ${TABLE}.country ;;
-  }
-
-  dimension: events {
-    type: string
-    sql: ${TABLE}.events ;;
-    hidden: yes
-  }
-
-  dimension: experiments {
-    hidden: yes
-    sql: ${TABLE}.experiments ;;
-  }
-
-  dimension: locale {
-    type: string
-    sql: ${TABLE}.locale ;;
-  }
-
-  dimension: normalized_channel {
-    type: string
-    sql: ${TABLE}.normalized_channel ;;
-  }
-
-  dimension: os {
-    type: string
-    sql: ${TABLE}.os ;;
-  }
-
-  dimension: sample_id {
-    type: number
-    sql: ${TABLE}.sample_id ;;
-  }
-
-  dimension: subdivision1 {
-    type: string
-    sql: ${TABLE}.subdivision1 ;;
-  }
-
-  dimension: submission_date {
-    type: date
-    sql: CAST(${TABLE}.submission_date AS TIMESTAMP) ;;
-  }
-}

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants