Skip to content

Check if default dimension exists when adding opmon filters#322

Merged
emtwo merged 1 commit intomainfrom
fix-opmon-default
Dec 7, 2021
Merged

Check if default dimension exists when adding opmon filters#322
emtwo merged 1 commit intomainfrom
fix-opmon-default

Conversation

@scholtzan
Copy link
Copy Markdown
Contributor

@scholtzan scholtzan commented Dec 7, 2021

Yesterdays run has been failing with:

[2021-12-07 16:39:50,967] {{pod_launcher.py:149}} INFO - Traceback (most recent call last):
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -   File "/usr/local/bin/lookml-generator", line 33, in <module>
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -     sys.exit(load_entry_point('lookml-generator', 'console_scripts', 'lookml-generator')())
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/__main__.py", line 9, in main
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -     cli("generator")
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/__init__.py", line 37, in cli
[2021-12-07 16:39:50,968] {{pod_launcher.py:149}} INFO -     group(prog_name=prog_name)
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -   File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -     return self.main(*args, **kwargs)
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -   File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1053, in main
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -     rv = self.invoke(ctx)
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -   File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -     return _process_result(sub_ctx.command.invoke(sub_ctx))
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -   File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -     return ctx.invoke(self.callback, **ctx.params)
[2021-12-07 16:39:50,969] {{pod_launcher.py:149}} INFO -   File "/usr/local/lib/python3.8/site-packages/click/core.py", line 754, in invoke
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -     return __callback(*args, **kwargs)
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/lookml.py", line 188, in lookml
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -     return _lookml(namespaces, glean_apps, target_dir)
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/lookml.py", line 152, in _lookml
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -     for explore_path in _generate_explores(
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/lookml.py", line 61, in _generate_explores
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -     "explores": explore.to_lookml(client, v1_name, namespace_data),
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/explores/explore.py", line 65, in to_lookml
[2021-12-07 16:39:50,970] {{pod_launcher.py:149}} INFO -     new_lookml = self._to_lookml(client, v1_name, data)
[2021-12-07 16:39:50,971] {{pod_launcher.py:149}} INFO -   File "/app/lookml-generator/generator/explores/operational_monitoring_explore.py", line 76, in _to_lookml
[2021-12-07 16:39:50,971] {{pod_launcher.py:149}} INFO -     {f"{base_view_name}.{dimension['name']}": dimension["default"]}
[2021-12-07 16:39:50,971] {{pod_launcher.py:149}} INFO - KeyError: 'default'

@scholtzan scholtzan requested a review from emtwo December 7, 2021 16:44
@emtwo emtwo merged commit 5947fa9 into main Dec 7, 2021
@emtwo emtwo deleted the fix-opmon-default branch December 7, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants