Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

start of docker docs#18

Closed
andymckay wants to merge 1 commit intomasterfrom
1053408
Closed

start of docker docs#18
andymckay wants to merge 1 commit intomasterfrom
1053408

Conversation

@andymckay
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread docs/topics/docker.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. Currently wharfie's checkout is assuming you'd set whoami to your username as it is going to checkout your forks and then it adds mozilla as an 'upstream' remote as part of the checkout command. As it stands this would result in the moz repos being origin and upstream remotes.

Maybe we can do it this way but we should think about changing wharfie's default behaviour. Also we should think about what remotes are set to and have a sane default. For example I use origin for my remote and upstream for the mozilla upstream. This approach matches github's docs. https://help.github.com/articles/fork-a-repo so it's a good default.

For these instructions to be good wharfie's command could be updated to use git clone --origin upstream [mozilla repo] maybe we leave adding the upstream origin out of this or have it as a separate command.

Despite the nits I like the approach of starting with the moz repos as that avoids the case of the user's forks being out of date.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise origin is my remote and master points at mozilla.

Cool with changing wharfie to do that differently, but yeah let's avoid someone having to fork everything.

@eviljeff
Copy link
Copy Markdown
Member

Can we get this landed and then iterate on it? Not have documentation is a significant barrier to wider testing.

@muffinresearch
Copy link
Copy Markdown
Contributor

Can we get this landed and then iterate on it? Not have documentation is a significant barrier to wider testing.

There's various bugs that exist that are a wider barrier to entry at the moment these exist around fundamental pieces re: cloning and repo setup. Until then I don't see much point landing this as it will only create more confusion and noise.

If you want to test this now please use the etherpad docs here: https://etherpad.mozilla.org/mkt-docker-dev-env-instructions. They're what these are based on and this way you can contribute to improvements and point out things that don't work.

If that's putting you off then I'd suggest waiting. I have the bugs on my plate to fix to smooth out the "start from nothing" experience, but unfortunately I have higher priority other bugs to fix before I can get to them.

@andymckay andymckay closed this Aug 29, 2014
@andymckay andymckay deleted the 1053408 branch September 18, 2014 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants