[fix bug 1129659] Display banner if user is authenticated.

[glogiotatidis]

No description provided.

[glogiotatidis]

@jgmize r?

[glogiotatidis]

I should add a never_cache decorator here since we we merged #127

[jgmize]

I believe this will cause the Vary: Cookie header to be set, which should effectively invalidate the cache without the @never_cache decorator, but I don't think the decorator hurts either.

[glogiotatidis]

rebased! @jgmize ping?

[jgmize]

Sorry @glogiotatidis, this apparently needs a re-rebase

[glogiotatidis]

this needs the css to be re-generated. if you don't mind review the code and I can rebase before merging.

[glogiotatidis]

Let's merge this before Ben files another bug that all locales are shown :)

[jgmize]

Actually @glogiotatidis, I'm beginning to question the value of showing all locales to authenticated users in prod: given that we needed to set up a separate environment for unauthenticated users to see all locales anyway in #153 (comment), is this even a use case that we still need to support?

[bensternthal]

I was trying to think of a use case for supporting this. More specifically if within the normal course content creation if a user would ever need to see all locales. I can not think of one.

If you can't either than I think l10n.masterfirefoxos.com is enough.

[jgmize]

Sorry @glogiotatidis this was nice work and would have been a good resolution of this bug, but in response to @bensternthal's comment above I'm going to go ahead and close this and WONTFIX the bug, and submit a separate PR to eliminate showing all locales to authenticated users in favor of using https://l10n.masterfirefoxos.com exclusively for previewing locales and versions.