only logout with POST, fixes #126 #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 96.65% 97.43% +0.78%
==========================================
Files 6 6
Lines 239 234 -5
==========================================
- Hits 231 228 -3
+ Misses 8 6 -2
Continue to review full report at Codecov.
|
|
Please also add a test with a request factory sending a |
tests/test_views.py
Outdated
| self.assertEqual(response.status_code, 302) | ||
| self.assertEqual(response.url, '/example-logout') | ||
| response = logout_view(request) | ||
| self.assertEqual(response.status_code, 405) |
There was a problem hiding this comment.
Is there a reason we want to test get when we only implement post? I suggest we remove this test if that doesn't affect coverage.
There was a problem hiding this comment.
You're right. It's simply part of Django. No point testing Django. Will remove.
| return import_from_settings('LOGOUT_REDIRECT_URL', '/') | ||
|
|
||
| def dispatch(self, request, *args, **kwargs): | ||
| def post(self, request): |
There was a problem hiding this comment.
What about CSRF? Does it work by default?
There was a problem hiding this comment.
Tests test that automatically. As long as the view doesn't have a csrf_exempt decorator it should be using CSRF.
|
|
I believe I've address the CSRF question. |
3 participants
No description provided.