Logout user from OP. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akatsoulas
commented
Nov 29, 2016
akatsoulas
commented
- Support post http method on logout.
Collaborator
Author
|
@johngian r? |
akatsoulas
force-pushed
the
post-logout
branch
3 times, most recently
from
da450f2 to
74249dd
Compare
Current coverage is 94.59% (diff: 72.22%)@@ master #67 diff @@
==========================================
Files 7 7
Lines 207 222 +15
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 200 210 +10
- Misses 7 12 +5
Partials 0 0
|
johngian
reviewed
Jan 10, 2017
| @@ -1,4 +1,7 @@ | |||
| import requests | |||
| import urllib | |||
Collaborator
There was a problem hiding this comment.
Please make this import python 3 friendly
try:
from urllib import urlencode
except ImportError:
from urllib.parse import urlencode
mozilla_django_oidc/views.py
Outdated
| logout_view_path = import_from_settings('OIDC_OP_LOGOUT_VIEW', '') | ||
| if logout_view_path: | ||
| logout_view = import_string(logout_view_path) | ||
| logout_view(request) |
Collaborator
There was a problem hiding this comment.
This one should be return logout_view(request).
akatsoulas
force-pushed
the
post-logout
branch
from
74249dd to
eac41fb
Compare
johngian
approved these changes
Jan 11, 2017
johngian
reviewed
Jan 11, 2017
| def logout(request): | ||
| """Log out the user from Auth0.""" | ||
| url = 'https//' + import_from_settings('OIDC_OP_DOMAIN') + '/v2/logout' | ||
| url += '?' + urllib.urlencode({ |
* Support post http method on logout.
akatsoulas
force-pushed
the
post-logout
branch
from
eac41fb to
98d7807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.