Skip to content

Bug 1211147 - [gui] allow to use debug builds in the gui #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bug 1211147 - [gui] allow to use debug builds in the gui #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions gui/mozregui/ui/inbound.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<item row="1" column="1">
<widget class="QLineEdit" name="end_changeset"/>
</item>
<item row="2" column="0">
<item row="3" column="0">
<widget class="QLabel" name="label_3">
<property name="toolTip">
<string> choose the inbound branch</string>
Expand All @@ -46,7 +46,7 @@
</property>
</widget>
</item>
<item row="2" column="1">
<item row="3" column="1">
<widget class="QLineEdit" name="inbound_branch">
<property name="toolTip">
<string>branch like [b2g-inbound|fx-team|...]</string>
Expand All @@ -56,6 +56,20 @@
</property>
</widget>
</item>
<item row="2" column="0">
<widget class="QLabel" name="label_4">
<property name="text">
<string>Build Type</string>
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="QComboBox" name="build_type">
<property name="toolTip">
<string>Choose a build type you want.</string>
</property>
</widget>
</item>
</layout>
</item>
</layout>
Expand Down
14 changes: 14 additions & 0 deletions gui/mozregui/wizard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,21 @@ class InboundPage(WizardSelectionRangePage):
SUBTITLE = "Select the inbound changesets range."
FIELDS = {"start_changeset": "start_changeset",
"end_changeset": "end_changeset",
"build_type": "build_type",
"inbound_branch": "inbound_branch"}
ID = 2

def __init__(self):
WizardPage.__init__(self)
self.build_type_model = QStringListModel()

def initializePage(self):
WizardSelectionRangePage.initializePage(self)
application_name = self.field('application').toPyObject()
self.build_type_model = QStringListModel(
[i for i in REGISTRY.get(str(application_name)).BUILD_TYPES])
self.ui.build_type.setModel(self.build_type_model)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkouss I'm curious about why it keeps telling me no attribute 'BUILD_TYPES'

Traceback (most recent call last):
File "/Users/mikeling/mozregression/gui/mozregui/wizard.py", line 202, in initializePage
[FC_REGISTRY.get(str(application_name)).BUILD_TYPES])
AttributeError: type object 'FirefoxConfig' has no attribute 'BUILD_TYPES'

def nextId(self):
return ProfilePage.ID

Expand Down Expand Up @@ -244,6 +256,8 @@ def options(self):
else:
kind = "changeset"
fetch_config.set_inbound_branch(options['inbound_branch'])
if options['build_type']:
fetch_config.set_build_type(options['build_type'])
if options['find_fix'] is False:
options['good_' + kind] = options.pop('start_' + kind)
options['bad_' + kind] = options.pop('end_' + kind)
Expand Down