Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Not filtering#55

Closed
sh1r0 wants to merge 2 commits intomozilla:masterfrom
sh1r0:not_filtering
Closed

Not filtering#55
sh1r0 wants to merge 2 commits intomozilla:masterfrom
sh1r0:not_filtering

Conversation

@sh1r0
Copy link
Contributor

@sh1r0 sh1r0 commented Feb 27, 2014

@camd: the original PR of NOTed filtering was closed by me. This branch is the new one for negation filtering that I rebased that branch on the latest master branch (w/ and/or switch). Could you help me check if this branch is ready to be merged?

Thanks,
-shiro

@camd
Copy link
Contributor

camd commented Mar 8, 2014

Hmm, unforunately, the travis tests are failing on this one, too. I have noticed sometimes you just have to run them again. However, they can only be re-triggered by the person who owns the pull request. If you can't determine the error, would you just try re-triggering them? You get there by clicking details above next to the failure. Then clicking the failed job. Then there should be a button somewhere in the upper right that looks like a refresh circle with an arrow, I believe.

@camd
Copy link
Contributor

camd commented Mar 8, 2014

I've played around this this a bit, and I must say it's brilliant. This is going to be really useful. And I like the UI of the strikeout text, etc.

However, I found one use-case that would be really useful for this, but doesn't seem to work. So say you have a test run with 10 cases and you have run 5 of them. What you would like to do is get a list of just the cases that have NOT been run yet. So in the view results area, go to cases. Filter on your test run. Then filter on each test result type of passed failed invalidated and blocked. That should show all the results, except the ones that have no result. this looks like it works. However, if you then negate all the results, you would expect to see only the cases that have never been run.

If you could get that to work, that would be awesome. FFOS has test runs on 3000 cases, and finding the ones that haven't been executed yet can be hard. This would be a great solution for that. Can you see if you can get that working?

Thanks! And, again, this is really awesome. What a cool feature. Nice work!

@sh1r0 sh1r0 closed this Jan 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants