Return unknown for unsupported codec in gecko #102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinetiknz
approved these changes
Jul 11, 2017
Collaborator
kinetiknz
left a comment
kinetiknz
left a comment
There was a problem hiding this comment.
LGTM, but questions about removing more code.
| AudioCodecSpecific::ES_Descriptor(_) => | ||
| mp4parse_codec::UNKNOWN, | ||
| AudioCodecSpecific::MP3 => | ||
| mp4parse_codec::MP3, |
Collaborator
There was a problem hiding this comment.
Remove these from them C API enum?
mp4parse_capi/src/lib.rs
Outdated
| TrackType::Unknown => return mp4parse_status::UNSUPPORTED, | ||
| }; | ||
|
|
||
| // Return UNKNOWN to gecko for unsupported format. |
Collaborator
There was a problem hiding this comment.
Rather than reference Gecko explicitly (since this library is nominally disconnected from Gecko), just say something about not wanting to support these formats in the API?
| mp4parse_codec::MP4V, | ||
| VideoCodecSpecific::ESDSConfig(_) => // Gecko doesn't support MP4V (14496-2) video. | ||
| mp4parse_codec::UNKNOWN, | ||
| VideoCodecSpecific::JPEG => |
Collaborator
There was a problem hiding this comment.
Is it worth keeping the internal parsing code and enum entries for JPEG, AC3/EC3 at this point?
Contributor
Author
There was a problem hiding this comment.
Yes, I'll remove them.
alfredoyang
force-pushed
the
return_unknown_codec
branch
3 times, most recently
from
320f0e8 to
b716d09
Compare
Collaborator
|
LGTM. Fine to merge as-is, but it'd be nice to clean up the references in boxes.rs too. |
Contributor
Author
|
Sure, thanks for review. |
alfredoyang
force-pushed
the
return_unknown_codec
branch
from
b716d09 to
cc17000
Compare
alfredoyang
force-pushed
the
return_unknown_codec
branch
from
cc17000 to
9644805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1379047