Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3560 +/- ##
==========================================
- Coverage 94.55% 94.45% -0.11%
==========================================
Files 127 131 +4
Lines 39627 39957 +330
Branches 39627 39957 +330
==========================================
+ Hits 37470 37742 +272
- Misses 1318 1366 +48
- Partials 839 849 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates pinned GitHub Action references across CI workflows and composite actions, keeping the repository’s automation dependencies current and consistent.
Changes:
- Bump
mozilla/actionsworkflow/action pins fromv1.0.4tov1.0.11across CI. - Update
actions/upload-artifactpins fromv7.0.0tov7.0.1where used. - Update select third-party action pins (e.g., Docker build/login actions, CodSpeed action, VM actions, Android setup action).
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/semver.yml | Update mozilla/actions semver reusable workflow pin. |
| .github/workflows/sanitize.yml | Update mozilla/actions rust/nss pins and upload-artifact pin. |
| .github/workflows/rustfmt.yml | Update mozilla/actions rustfmt reusable workflow pin. |
| .github/workflows/readme.yml | Update mozilla/actions/rust pin used for cargo-readme. |
| .github/workflows/qns.yml | Update Docker login/build action pins for publishing QNS image. |
| .github/workflows/qns-pr.yml | Update Docker build action pin and upload-artifact pin for PR QNS builds. |
| .github/workflows/profile.yml | Update mozilla/actions rust/nss pins and upload-artifact pins in profiling workflows. |
| .github/workflows/perfcompare.yml | Update mozilla/actions/rust and upload-artifact pins for perf exports. |
| .github/workflows/mutants.yml | Update mozilla/actions rust/nss pins and upload-artifact pins for mutation testing. |
| .github/workflows/mutants-pr.yml | Update mozilla/actions rust/nss pins and upload-artifact pin for PR mutation testing. |
| .github/workflows/machete.yml | Update mozilla/actions machete reusable workflow pin. |
| .github/workflows/fuzz-corpus.yml | Update mozilla/actions rust/nss pins for fuzz corpus workflow. |
| .github/workflows/fuzz-bench.yml | Update mozilla/actions rust/nss pins for fuzz benchmark workflow. |
| .github/workflows/firefox.yml | Update upload-artifact pin used for Firefox packaging artifacts. |
| .github/workflows/dependency-review.yml | Update mozilla/actions dependency-review reusable workflow pin. |
| .github/workflows/deny.yml | Update mozilla/actions deny reusable workflow pin. |
| .github/workflows/codspeed.yml | Update mozilla/actions rust/nss pins and bump CodSpeed action pin. |
| .github/workflows/clippy.yml | Update mozilla/actions/toolchains, rust, and nss pins for clippy workflow. |
| .github/workflows/claude.yml | Update mozilla/actions/claude-review pin in both trusted/untrusted jobs. |
| .github/workflows/check.yml | Update mozilla/actions/toolchains, rust, nss pins and upload-artifact pin in main CI. |
| .github/workflows/check-mtu.yml | Update mozilla/actions/rust pin for MTU checks. |
| .github/workflows/bench.yml | Update mozilla/actions/rust pin and upload-artifact pins for bench exports. |
| .github/workflows/actionlint.yml | Update mozilla/actions actionlint reusable workflow pin. |
| .github/actions/quic-interop-runner/action.yml | Update upload-artifact pins used to publish interop logs/results. |
| .github/actions/quic-build/action.yml | Update mozilla/actions/rust pin and upload-artifact pin in build helper. |
| .github/actions/pr-comment-data-export/action.yml | Update upload-artifact pin used to export PR comment data. |
| .github/actions/check-vm/action.yml | Update FreeBSD/OpenBSD VM action pins. |
| .github/actions/check-android/action.yml | Update Android setup action pin and mozilla/actions rust/nss pins. |
| .github/actions/build-neqo/action.yml | Update mozilla/actions rust/nss pins and upload-artifact pin for build packaging. |
Contributor
Benchmark resultsNo significant performance differences relative to 5f256f2. All resultstransfer/1-conn/1-100mb-resp (aka. Download)/mtu-1504: Change within noise threshold. time: [204.13 ms 204.54 ms 205.05 ms]
thrpt: [487.68 MiB/s 488.89 MiB/s 489.89 MiB/s]
change:
time: [+0.0361% +0.2918% +0.5927] (p = 0.03 < 0.05)
thrpt: [-0.5892% -0.2910% -0.0361]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS)/mtu-1504: No change in performance detected. time: [283.40 ms 285.17 ms 286.93 ms]
thrpt: [34.852 Kelem/s 35.066 Kelem/s 35.285 Kelem/s]
change:
time: [-1.1504% -0.2031% +0.7169] (p = 0.67 > 0.05)
thrpt: [-0.7118% +0.2035% +1.1638]
No change in performance detected.transfer/1-conn/1-1b-resp (aka. HPS)/mtu-1504: No change in performance detected. time: [38.766 ms 38.936 ms 39.124 ms]
thrpt: [25.559 B/s 25.683 B/s 25.796 B/s]
change:
time: [-1.0011% -0.3186% +0.3333] (p = 0.35 > 0.05)
thrpt: [-0.3322% +0.3196% +1.0112]
No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload)/mtu-1504: Change within noise threshold. time: [205.65 ms 206.07 ms 206.53 ms]
thrpt: [484.19 MiB/s 485.26 MiB/s 486.26 MiB/s]
change:
time: [+0.1536% +0.4807% +0.8075] (p = 0.00 < 0.05)
thrpt: [-0.8010% -0.4784% -0.1534]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severestreams/walltime/1-streams/each-1000-bytes: Change within noise threshold. time: [589.47 µs 590.86 µs 592.61 µs]
change: [-1.8420% -1.2780% -0.7902] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.443 ms 12.464 ms 12.486 ms]
change: [-0.8352% -0.5874% -0.3522] (p = 0.00 < 0.05)
Change within noise threshold.streams/walltime/1000-streams/each-1000-bytes: No change in performance detected. time: [45.593 ms 45.636 ms 45.678 ms]
change: [-0.3650% -0.1608% +0.0150] (p = 0.10 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/walltime/pacing-false/varying-seeds: No change in performance detected. time: [78.615 ms 78.681 ms 78.755 ms]
change: [-0.2464% -0.1124% +0.0236] (p = 0.11 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severetransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [79.955 ms 80.027 ms 80.103 ms]
change: [-0.3722% -0.2554% -0.1485] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severetransfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [78.372 ms 78.478 ms 78.619 ms]
change: [-2.4805% -2.3203% -2.1383] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severetransfer/walltime/pacing-true/same-seed: No change in performance detected. time: [80.270 ms 80.394 ms 80.557 ms]
change: [-0.1695% +0.0754% +0.3015] (p = 0.56 > 0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severeDownload data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 5f256f2. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.