Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the mtu workspace crate’s package version for an upcoming publish, ensuring the workspace lockfile reflects the new version.
Changes:
- Update
mtucrate version from0.4.0to0.4.1. - Update the
Cargo.lockentry formtuto match the new crate version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
mtu/Cargo.toml |
Increments the mtu crate package version to 0.4.1. |
Cargo.lock |
Updates the locked workspace package metadata for mtu to 0.4.1. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Straightforward patch version bump for mtu 0.4.0 → 0.4.1, presumably to unblock cargo publish after workspace-related publishing issues. Changes are limited to mtu/Cargo.toml and the corresponding Cargo.lock entry, plus a trailing-newline cleanup.
No concerns:
neqo-transportdepends onmtuviapath = "../mtu", so no downstream version pins need updating.- Patch bump is appropriate — no public API changes.
Cargo.lockis consistent with the version change.
Member
I am not following. Can you expand? You can publish individual crates of a workspace. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
==========================================
+ Coverage 94.37% 94.42% +0.04%
==========================================
Files 133 133
Lines 40081 40081
Branches 40081 40081
==========================================
+ Hits 37828 37845 +17
+ Misses 1406 1390 -16
+ Partials 847 846 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
larseggert
force-pushed
the
chore-mtu-0.4.1
branch
from
88df006 to
e2397f7
Compare
Contributor
There was a problem hiding this comment.
Clean patch-bump to unblock cargo publish from the workspace.
What this does:
- Bumps
mtu0.4.0 → 0.4.1 (version + lockfile consistent). - Inlines
categoriesandreadmeinmtu/Cargo.toml— the workspace-inherited values were wrong for standalone publishing ("web-programming"doesn't apply tomtu, and the workspacereadmewould resolve to the rootREADME.md). - Fixes stale links in
README.mdandSECURITY.mdto point atmozilla/neqo(post-monorepo move) and corrects the Firefox vendored path frommtu-transporttomtu. - Fixes "activly" → "actively" typo.
No code changes, no API surface changes. LGTM.
With some minor metadata corrections.
larseggert
force-pushed
the
chore-mtu-0.4.1
branch
from
e2397f7 to
87c5e33
Compare
Collaborator
Author
I got confused because the |
Contributor
There was a problem hiding this comment.
Clean patch bump to unblock cargo publish from the workspace. Changes are well-scoped:
- Version 0.4.0 → 0.4.1 with consistent
Cargo.lockupdate. - Workspace-inherited
license,categories, andreadmecorrectly inlined for standalone publishing.categoriesappropriately narrowed from["network-programming", "web-programming"]to["network-programming"]. - Stale links updated to
mozilla/neqopost-monorepo move; vendored Firefox paths corrected frommtu-transporttomtu. - No API or code changes; patch bump is semver-appropriate.
LGTM.
Contributor
Benchmark resultsSignificant performance differences relative to 824b15d. transfer/1-conn/1-100mb-req (aka. Upload): 💔 Performance has regressed by +1.4333%. time: [207.02 ms 207.46 ms 208.01 ms]
thrpt: [480.75 MiB/s 482.01 MiB/s 483.05 MiB/s]
change:
time: [+1.1209% +1.4333% +1.7825] (p = 0.00 < 0.05)
thrpt: [-1.7513% -1.4131% -1.1085]
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severeAll resultstransfer/1-conn/1-100mb-resp (aka. Download): Change within noise threshold. time: [205.48 ms 205.85 ms 206.26 ms]
thrpt: [484.81 MiB/s 485.78 MiB/s 486.66 MiB/s]
change:
time: [+0.8900% +1.1567% +1.4134] (p = 0.00 < 0.05)
thrpt: [-1.3937% -1.1434% -0.8821]
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS): No change in performance detected. time: [285.68 ms 287.51 ms 289.40 ms]
thrpt: [34.554 Kelem/s 34.781 Kelem/s 35.005 Kelem/s]
change:
time: [-1.4550% -0.5337% +0.4141] (p = 0.26 > 0.05)
thrpt: [-0.4124% +0.5366% +1.4765]
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildtransfer/1-conn/1-1b-resp (aka. HPS): No change in performance detected. time: [39.241 ms 39.384 ms 39.548 ms]
thrpt: [25.286 B/s 25.391 B/s 25.483 B/s]
change:
time: [-0.3490% +0.1916% +0.6838] (p = 0.48 > 0.05)
thrpt: [-0.6792% -0.1912% +0.3503]
No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) high mild
5 (5.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload): 💔 Performance has regressed by +1.4333%. time: [207.02 ms 207.46 ms 208.01 ms]
thrpt: [480.75 MiB/s 482.01 MiB/s 483.05 MiB/s]
change:
time: [+1.1209% +1.4333% +1.7825] (p = 0.00 < 0.05)
thrpt: [-1.7513% -1.4131% -1.1085]
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severestreams/walltime/1-streams/each-1000-bytes: No change in performance detected. time: [596.28 µs 598.04 µs 600.16 µs]
change: [-0.0046% +0.5146% +1.0176] (p = 0.06 > 0.05)
No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [12.358 ms 12.390 ms 12.435 ms]
change: [+0.3503% +0.7541% +1.2334] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severestreams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [44.834 ms 44.884 ms 44.940 ms]
change: [+0.3578% +0.5187% +0.6772] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [78.511 ms 78.588 ms 78.685 ms]
change: [-1.7712% -1.5532% -1.3701] (p = 0.00 < 0.05)
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
3 (3.00%) high mild
2 (2.00%) high severetransfer/walltime/pacing-true/varying-seeds: Change within noise threshold. time: [79.635 ms 79.702 ms 79.775 ms]
change: [-1.1639% -0.9705% -0.8172] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [78.133 ms 78.194 ms 78.259 ms]
change: [-2.2214% -2.0059% -1.8362] (p = 0.00 < 0.05)
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mildtransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [79.764 ms 79.812 ms 79.861 ms]
change: [-1.8731% -1.7271% -1.5982] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildDownload data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 824b15d. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because apparently in a workspace you can't justcargo publishin a subdirectory...