chore: Bump the competing stacks to latest versions#3567
Merged
larseggert merged 1 commit intomozilla:mainfrom Apr 18, 2026
Merged
chore: Bump the competing stacks to latest versions#3567larseggert merged 1 commit intomozilla:mainfrom
larseggert merged 1 commit intomozilla:mainfrom
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Straightforward CI-only version bump for competing QUIC stacks used in interop/benchmark testing. Changes are well-scoped:
- msquic v2.5.6 → v2.5.7 (patch)
- google/quiche commit ref updated
- s2n-quic v1.72.0 → v1.77.0 (minor)
- bazelisk v1.25.0 → v1.28.1 (build tool, minor)
- cloudflare/quiche unchanged at 0.24.5
- CACHE_VERSION v2 → v3 — correctly invalidated to pick up the new builds
No concerns. The cache key already incorporates the individual version strings (line 66), so the CACHE_VERSION bump is belt-and-suspenders but harmless and consistent with the comment on line 28.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the pinned versions/refs used by the quic-build composite GitHub Action to keep the “competing stacks” used in perf comparisons up to date.
Changes:
- Bumped cache invalidation version (
CACHE_VERSION) tov3. - Updated pinned versions/refs for msquic, google/quiche, and s2n-quic.
- Updated the Bazelisk download version used for building google/quiche.
Comment on lines
118
to
120
| sudo curl -fsSL -o /usr/local/bin/bazel \ | ||
| "https://github.com/bazelbuild/bazelisk/releases/download/v1.25.0/bazelisk-linux-$ARCH" | ||
| "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-$ARCH" | ||
| sudo chmod +x /usr/local/bin/bazel |
There was a problem hiding this comment.
The Bazelisk version is hardcoded in the download URL here, but the cache key for the google/quiche build is computed earlier (before Bazel is installed) and therefore typically falls back to BAZEL_VER=unknown. That means changing the Bazelisk version won’t naturally invalidate the google build cache unless CACHE_VERSION is bumped. Consider defining a BAZELISK_VERSION alongside the other pinned versions and using it both in the download URL and in the cache key calculation for impl=google.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3567 +/- ##
==========================================
- Coverage 94.56% 94.44% -0.12%
==========================================
Files 128 133 +5
Lines 39818 40163 +345
Branches 39818 40163 +345
==========================================
+ Hits 37653 37932 +279
- Misses 1329 1383 +54
- Partials 836 848 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Benchmark resultsNo significant performance differences relative to a1331f5. All resultstransfer/1-conn/1-100mb-resp (aka. Download): Change within noise threshold. time: [208.97 ms 209.33 ms 209.73 ms]
thrpt: [476.80 MiB/s 477.72 MiB/s 478.53 MiB/s]
change:
time: [+0.0637% +0.3108% +0.5242] (p = 0.01 < 0.05)
thrpt: [-0.5215% -0.3098% -0.0636]
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/1-conn/10_000-parallel-1b-resp (aka. RPS): No change in performance detected. time: [286.49 ms 288.59 ms 290.75 ms]
thrpt: [34.394 Kelem/s 34.651 Kelem/s 34.905 Kelem/s]
change:
time: [-0.8055% +0.1435% +1.1608] (p = 0.78 > 0.05)
thrpt: [-1.1475% -0.1433% +0.8121]
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/1-conn/1-1b-resp (aka. HPS): No change in performance detected. time: [38.790 ms 38.943 ms 39.117 ms]
thrpt: [25.564 B/s 25.679 B/s 25.780 B/s]
change:
time: [-1.1668% -0.5238% +0.1056] (p = 0.11 > 0.05)
thrpt: [-0.1055% +0.5266% +1.1806]
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severetransfer/1-conn/1-100mb-req (aka. Upload): No change in performance detected. time: [208.88 ms 209.22 ms 209.60 ms]
thrpt: [477.09 MiB/s 477.96 MiB/s 478.75 MiB/s]
change:
time: [-0.1182% +0.1194% +0.3638] (p = 0.32 > 0.05)
thrpt: [-0.3624% -0.1193% +0.1184]
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severestreams/walltime/1-streams/each-1000-bytes: No change in performance detected. time: [589.78 µs 591.71 µs 593.95 µs]
change: [-0.6311% +0.0221% +0.6442] (p = 0.94 > 0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) high mild
7 (7.00%) high severestreams/walltime/1000-streams/each-1-bytes: No change in performance detected. time: [12.273 ms 12.315 ms 12.382 ms]
change: [-0.0122% +0.3938% +1.0508] (p = 0.11 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severestreams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [44.345 ms 44.389 ms 44.435 ms]
change: [+0.2607% +0.4948% +0.6909] (p = 0.00 < 0.05)
Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [81.360 ms 81.413 ms 81.468 ms]
change: [-1.8133% -1.6669% -1.5226] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
3 (3.00%) high mildtransfer/walltime/pacing-true/varying-seeds: No change in performance detected. time: [82.644 ms 82.699 ms 82.753 ms]
change: [-0.2096% -0.0298% +0.1135] (p = 0.76 > 0.05)
No change in performance detected.transfer/walltime/pacing-false/same-seed: No change in performance detected. time: [81.017 ms 81.071 ms 81.128 ms]
change: [-0.2270% -0.1065% +0.0046] (p = 0.08 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severetransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [83.046 ms 83.095 ms 83.145 ms]
change: [+0.0482% +0.1774% +0.2925] (p = 0.00 < 0.05)
Change within noise threshold.Download data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to a1331f5. No significant performance differences. Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.