-
Notifications
You must be signed in to change notification settings - Fork 137
Add eslint-plugin-mozilla plugin #478
Conversation
| const defaultThemeLabel = document.getElementById('default_label'); | ||
| const darkThemeLabel = document.getElementById('dark_label'); | ||
|
|
||
| /* eslint-disable no-unsanitized/property */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just disabled the rule for these 3 lines. Not sure if there is some "sanitization" module we wanted to use or something to make sure there aren't any potential XSS leaks from the l10n files.
|
@pdehaan we shall take a look at it once we tag the sync build, thanks for the pr! |
|
@pdehaan Could you please rebase this? |
|
@pdehaan could you please rebase this ? |
fa3d768 to
676c099
Compare
676c099 to
7ab2cee
Compare
|
@vladikoff Consider yourself rebased... I also bumped the eslint-plugin-mozilla and eslint dependency versions and ran I also noticed that indenting may be a bit funky in some places since we don't seem to have any Line 67 in 03cd44a
|
|
Thanks @pdehaan we will definitely add prettier while moving to a React.JS codebase. |
|
@pdehaan thank you! |
so, @vladikoff did you? :) |
|
@pdehaan any luck adding that ^ ? |
No description provided.