syncing used instead of saving while logged in

[himanish-star]

fixes : #597

Changes can be seen in the GIF below

[flodolo]

If you change a string you also need to change the associated ID
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Also make sure to update the reference in comments (if available)

[Natim]

This is not the proper way of fixing the issue. You can't change the property file like that.

[himanish-star]

@Natim , I was about to fix this. Could you reopen this PR ? I'll try this another way. Or do you want me to file a new PR

[himanish-star]

This is with respect to #597 (comment)

After a note has been edited, footer should say "Syncing…"

I tried searching for the word "Syncing" but I found out "Syncing changes". Thus I have used this as you have told me that I can't edit the property file like that.

Before a note has been edited it should say "Last Synced HH:MM"

Same for this I couldn't find "Last Synced" so I did it with "Synced at" instead.

It does this but also has Save and Saving…

So do you want me to remove this. For now I have removed this , if you want it back then I'll fix this back too 😃
Here's the new GIF

---

If this is not what you want, then could you explain me a bit more 😃

[himanish-star]

@Natim , any views on the recent changes ?

[Natim]

The problem is that now you don't have the saving changes when we are not logged in have you?

@ryanfeeley can you confirm this is correct according to the new specs?

When not logged in

1. Saving changes...
2. All changes saved

When sync activated

1. Syncing changes...
2. Synced 7:24 PM

[Natim]

@himanish-star You can use the changesSaved property for All changes saved and syncComplete2 for Synced at 7:24 PM

[Natim]

If we need to go back to Synced 7:24 PM it is a regression of #467 and @ryanfeeley @vladikoff and @flodolo need to talk to figure out what made that change that I don't remember.

[himanish-star]

Ok, @Natim , I have started correcting my work

[Natim]

Writting the following made me understand why we added the at inside:

# LOCALIZATION NOTE (syncComplete3): {time} is the time of last sync. If this
# structure doesn't work for your locale, you can translate this as "Synced at {time}".
syncComplete3=Synced {time}

@ryanfeeley is that really what we want?

[ryanfeeley]

@Natim Yes, an example like Synced 7:24 PM is perfect. Same for Saved 7:24 PM.

[himanish-star]

This is a new GIF. Please see the changes

---

The above changes are with respect to
#601 (comment)

[ryanfeeley]

@himanish-star Is it putting the new text at the end (where the cursor is) or the beginning? Hard to tell as it's the same text.

[himanish-star]

Well it's putting the text according to the previous caret position. There is an issue already on this #532

[Natim]

Just a little refactoring.

[Natim]

I guess you can have a if for the !waitingToReconnect and another one for the isAuthenticated condition.

[himanish-star]

Oh, I just saw this now. Well thanks for changing 😃

Review fixed