Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Use 100vh so that the footer doesn't bounce. #603

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Use 100vh so that the footer doesn't bounce. #603

merged 1 commit into from
Jan 23, 2018

Conversation

@Natim
Copy link
Collaborator

@Natim Natim commented Jan 22, 2018

Fixes #600 via @johngruen

@Natim
Copy link
Collaborator Author

Natim commented Jan 22, 2018 •
edited
Loading

Hi @Softvision-CristinaBadescu
Can I let you try this branch and see if it fixes #600?
Addon: addon-fixes-600-questionmark.zip

@Softvision-CristinaBadescu
Copy link

Softvision-CristinaBadescu commented Jan 23, 2018

Hello @Natim, thanks for looking into this.

I've tested this issue with the provided build, but it didn't solved the bug because it is still reproducible on latest Nightly build 60.0a1 (2018-01-22), on Windows 10 x64 and Ubuntu 14.04 x64.

However, this issue is not reproducible on Mac 10.12.6, on latest Nightly build 60.a1 (2018-01-22), using Firefox Notes v2.2.0dev (custom build 2018-01-23), Firefox Notes from Test Pilot experiments page or the provided build from your last comment.

@Natim
Copy link
Collaborator Author

Natim commented Jan 23, 2018

Ok I guess it is an improvment then. I am merging this and we will figure it out later for other impacted releases.

@Natim Natim merged commit 2850256 into master Jan 23, 2018
@Natim Natim deleted the 600-try-not-to-bounce-footer branch January 23, 2018 09:21
Natim pushed a commit that referenced this pull request Jan 24, 2018
Revert "Merge pull request #603 from mozilla/600-try-not-to-bounce-fo…
0737bee 
…oter"

This reverts commit 2850256, reversing
changes made to 2a9dc66.
@Natim
Copy link
Collaborator Author

Natim commented Jan 24, 2018 •
edited
Loading

I had to revert that because the scrolling of the editor was broken with it. — 0737bee

@Softvision-CristinaBadescu Softvision-CristinaBadescu mentioned this pull request May 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Natim @Softvision-CristinaBadescu @johngruen