This repository was archived by the owner on Jan 6, 2023. It is now read-only.
last sync text color fixed (#574) #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Natim
reviewed
Feb 1, 2018
src/sidebar/editor.js
Outdated
|
|
||
| if (syncSuccess === true && !footerButtons.classList.contains('syncSuccess')) { | ||
| footerButtons.classList.add('syncSuccess'); | ||
| } else if (footerButtons.classList.contains('syncSuccess')) { |
Collaborator
There was a problem hiding this comment.
Can we change the if clause to have a else clause here?
Natim
reviewed
Feb 1, 2018
src/sidebar/styles.css
Outdated
| color: black; | ||
| } | ||
|
|
||
| #footer-buttons.syncSuccess div:first-child { |
Collaborator
There was a problem hiding this comment.
I guess we can add the condition close in the previous CSS rule line 125.
Contributor
Author
|
@Natim, on it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to issue #574 , added styling to make the "Synced at (time)" text black. First pull request, let me know how this looks!