Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

open/close detection fix #657

Merged
merged 4 commits into from
Feb 5, 2018
Merged

open/close detection fix #657

merged 4 commits into from
Feb 5, 2018

Conversation

@muddlebee
Copy link
Contributor

@muddlebee muddlebee commented Feb 2, 2018 •
edited
Loading

fix #656
@vladikoff please review

@vladikoff
Copy link
Contributor

vladikoff commented Feb 4, 2018

@anweshknayak this should remove all code related to addonIsClosedForWindow and final version should probably be something like

browser.browserAction.onClicked.addListener(() => {
  browser.sidebarAction.open();
});

vladikoff
vladikoff previously requested changes Feb 4, 2018
View reviewed changes
Copy link
Contributor

@vladikoff vladikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@muddlebee
Copy link
Contributor Author

muddlebee commented Feb 4, 2018

@vladikoff thanks a lot 😄

@Natim
Copy link
Collaborator

Natim commented Feb 5, 2018

Thanks

@Natim Natim merged commit 1ae87d8 into mozilla:master Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Natim Natim Natim approved these changes

@vladikoff vladikoff vladikoff left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Always open the notepad when the notes button is pressed

3 participants

@muddlebee @vladikoff @Natim