Skip to content

Remove files for the maemo platform from the db (bug 1119800)#416

Merged
magopian merged 1 commit intomozilla:masterfrom
magopian:1119800-remove-maemo-files-from-db
Jan 12, 2015
Merged

Remove files for the maemo platform from the db (bug 1119800)#416
magopian merged 1 commit intomozilla:masterfrom
magopian:1119800-remove-maemo-files-from-db

Conversation

@magopian
Copy link
Copy Markdown
Contributor

Fixes bug 1119800

This removes 95 files with the maemo platform at the time of the writing.

@diox
Copy link
Copy Markdown
Member

diox commented Jan 12, 2015

Do we also need to do something for the old PLATFORM_ALL_MOBILE (id 9) ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase FILES ?

@diox
Copy link
Copy Markdown
Member

diox commented Jan 12, 2015

I wonder if this can have other implications. Like, if a Version only has one File and that File was for maemo, isn't this going to break things ?

@magopian magopian force-pushed the 1119800-remove-maemo-files-from-db branch from 56c67ac to 9f19258 Compare January 12, 2015 17:20
@magopian
Copy link
Copy Markdown
Contributor Author

Regarding the PLATFORM_ALL_MOBILE (id 9) I don't believe it's used as the files.platform_id at all (there's no entry in the database at least).

From what I can see in the database, no version has only one file, so we shouldn't have any issue on that side either:

mysql> select count(*) from versions where id in (select version_id from files where platform_id=8) and id not in (select version_id from files where platform_id!=8);
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0,26 sec)

@diox
Copy link
Copy Markdown
Member

diox commented Jan 12, 2015

r+

magopian added a commit that referenced this pull request Jan 12, 2015
Remove files for the maemo platform from the db (bug 1119800)
@magopian magopian merged commit de650bc into mozilla:master Jan 12, 2015
@magopian magopian deleted the 1119800-remove-maemo-files-from-db branch January 12, 2015 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants