Build a new devhub status UI for the unlisted addons (bug 1122109)#494
Merged
magopian merged 1 commit intomozilla:masterfrom Apr 3, 2015
Merged
Conversation
magopian
changed the title
magopian
force-pushed
the
1122109-devhub-unlisted-status-ui
branch
2 times, most recently
from
94e1f9d to
9b99b9e
Compare
magopian
changed the title
magopian
force-pushed
the
1122109-devhub-unlisted-status-ui
branch
2 times, most recently
from
4e0621e to
4031576
Compare
Member
There was a problem hiding this comment.
Add a check for data-url to help make sure the JS is going to work, since we don't have front-end tests ?
Contributor
Author
There was a problem hiding this comment.
excellent idea, well spotted!
magopian
force-pushed
the
1122109-devhub-unlisted-status-ui
branch
2 times, most recently
from
866c702 to
6155641
Compare
Member
There was a problem hiding this comment.
Why do we need this title and then below another ("Addon visibility") ?
Contributor
Author
There was a problem hiding this comment.
See the alternate image in the PR description, is it better?
magopian
force-pushed
the
1122109-devhub-unlisted-status-ui
branch
from
6155641 to
36abe5b
Compare
Member
|
r+ with the title shuffle |
magopian
added a commit
that referenced
this pull request
Apr 3, 2015
Build a new devhub status UI for the unlisted addons (bug 1122109)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug 1122109