Skip to content

Change the background to gradient from pin stripe and made footer solid color. (bug 1170302)#574

Closed
FrancescoSTL wants to merge 3 commits into
mozilla:masterfrom
FrancescoSTL:bug-1170302-Removing-pin-stripe
Closed

Change the background to gradient from pin stripe and made footer solid color. (bug 1170302)#574
FrancescoSTL wants to merge 3 commits into
mozilla:masterfrom
FrancescoSTL:bug-1170302-Removing-pin-stripe

Conversation

@FrancescoSTL
Copy link
Copy Markdown
Contributor

@FrancescoSTL FrancescoSTL changed the title Changed the background to gradient from pin stripe and made footer solid color Change the background to gradient from pin stripe and made footer solid color Jun 4, 2015
@magopian
Copy link
Copy Markdown
Contributor

magopian commented Jun 8, 2015

Is there a bug number for that?

It seems after this change, we're not using the bg-header.png file, which could thus be removed (use git rm for that):

./site-static/img/zamboni/global/bg-header.png
./static/img/zamboni/global/bg-header.png

Thanks!

@FrancescoSTL
Copy link
Copy Markdown
Contributor Author

Yes! The bug number is 1170302. I just removed bg-header.png.

@FrancescoSTL FrancescoSTL changed the title Change the background to gradient from pin stripe and made footer solid color Change the background to gradient from pin stripe and made footer solid color (bug 1170302) Jun 8, 2015
@FrancescoSTL FrancescoSTL changed the title Change the background to gradient from pin stripe and made footer solid color (bug 1170302) Change the background to gradient from pin stripe and made footer solid color. (bug 1170302) Jun 8, 2015
@FrancescoSTL
Copy link
Copy Markdown
Contributor Author

Here is what the experience now looks like:
screen shot 2015-06-08 at 9 51 50 am

and this is what it previously looked like:
screen shot 2015-06-08 at 11 19 56 am

@magopian
Copy link
Copy Markdown
Contributor

magopian commented Jun 8, 2015

The files in site-static are actually generated and only used in production (or at least, not locally during the dev as long as you have DEBUG = True in the settings).

thanks for the removal of the file, and for the screenshots!

@FrancescoSTL
Copy link
Copy Markdown
Contributor Author

Is there any way that these two PR's can be pushed at the same time?

@magopian
Copy link
Copy Markdown
Contributor

magopian commented Jun 8, 2015

Sure, i'll merge them both tomorrow, and whenever they'll go live, they should be pushed together.

@magopian
Copy link
Copy Markdown
Contributor

magopian commented Jun 9, 2015

Merged in 9ecb505

@magopian magopian closed this Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants