Mark as webpack 4 compatible

[lorefnon]

The webpack version in pdfjs-dist is currently "^2.0.0 || ^3.0.0" though it works well with "^4.0.0" as well.

Can you please mark this as 4.x compatible ?

Webpack 4 has been out for a while and my applications currently using webpack 4.x are using pdfjs-dist without any problems but when I run npm install I get a spurious peer dependency version mismatch warning which I'd like to get rid of.

[timvandermeij]

I tried upgrading to Webpack 4 before and even though it worked locally (with a few minor tweaks), the testing infrastructure choked on it for reasons still unknown to me. Perhaps we should try again.

[lorefnon]

Hi Tim, thanks for looking into this.

If you could point me to the build errors (with webpack 4) I might be able to help with the investigation.

[timvandermeij]

There were no build errors locally, but the test bots timed out after not being able to start the tests after 120 seconds, both on Windows and Linux. I do not recall having seen any errors in those logs.

[d4nc3r]

@timvandermeij is there anything we can do to help? I am also running into this problem - and since I'm at a very large company we need to use a shrinkwrap file, and can't shrinkwrap with errors or warnings :(

[jasco]

Currently debugging a case where webpack 4 production output of pdfjs-dist worker appears to render a mangled font in one particular case. Using a debug build of the worker works fine. Have not yet verified webpack 3 behavior because downgrading my config is proving troublesome.

[Codii]

@jasco Any news on this issue ? Did you find hints on what causes the mangled fonts ?

[jasco]

@Codii yes, actually I did resolve the issue. It was tied to using webpack production optimizations on the PDF worker script. I ended up using the pdfjs-dist distribution's minified worker script as-is without running it through webpack.

I did not really dig into why exactly webpack was causing a problem.

[timvandermeij]

Fixed by the pull request above.

[denkrasnov]

Hi, when I switched to webpack 4 and changed the way to set up worker from import pdfjsLib from "pdfjs-dist/webpack"; to pdfjsLib.GlobalWorkerOptions.workerSrc = "/resources/pdf.worker.js"; I faced a problem that worker doesn't work. Despite the fact that the file pdf.worker.js exists in the bundle and is accessible I see the warning in the console Warning: Setting up fake worker.. Did I miss something? Does anyone have any ideas? 🤔

[Kailaash-Balachandran]

@DenisKrasnov I'm facing similar issue. How did you resolve this?

[Maskik]

Looks like it resolved in this solution

try this:

import { PDFJS } from 'pdfjs-dist/build/pdf.combined';
import 'pdfjs-dist/web/compatibility';

maybe you need to use lower version "pdfjs-dist": "1.8.357"