Update dependencies and translations to the most recent versions#15508
Conversation
|
/botio-linux preview |
|
/botio test |
|
In addition to existing intermittent integration-test failures, it seems that this PR introduces one new problem on both bots (see excerpt below). I'd guess that the Puppeteer update might be somehow responsible, and thus require the test(s) to be tweaked. |
|
I'll have a look at that. Sadly the integration tests are quite flaky lately :-/ |
|
It might be too simplistic, and possibly not robust enough, but would it work if we simply delayed trying to find the active element a little bit? Basically change pdf.js/test/integration/scripting_spec.js Lines 56 to 59 in a93c01a const id = await page.evaluate(async () => {
await new Promise(resolve => setTimeout(resolve, 0));
const element = window.document.activeElement;
return element.getAttribute("data-element-id");
}); |
…" scripting test This commit fixes the "Expected null to equal '401R'" errors that surfaced after the Puppeteer 18 upgrade. Note that even before that this would have been an improvement because it takes some time between scripting being reported ready (i.e., triggering the execution of any OpenActions) and those OpenActions actually completing execution, so it's only safe to check which element is focused if we know an element actually became focused.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8314cac3ef26baf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8314cac3ef26baf/output.txt Total script time: 2.12 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/36a84201351e1c1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/112158bea6e9363/output.txt |
Snuffleupagus
left a comment
There was a problem hiding this comment.
r=me, with passing tests; thank you!
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/112158bea6e9363/output.txt Total script time: 26.00 mins
Image differences available at: http://54.241.84.105:8877/112158bea6e9363/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/36a84201351e1c1/output.txt Total script time: 29.02 mins
Image differences available at: http://54.193.163.58:8877/36a84201351e1c1/reftest-analyzer.html#web=eq.log |
The major version bumps don't seem to contain any breaking changes for us; please refer to:
eslint-plugin-unicorn: https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v44.0.0jstransformer-markdown-it: jstransformers/jstransformer-markdown-it@2.1.0...v3.0.0puppeteer: https://github.com/puppeteer/puppeteer/releasesvinyl: https://github.com/gulpjs/vinyl/releases/tag/v3.0.0