Skip to content

Update dependencies and translations to the most recent versions#15508

Merged
timvandermeij merged 3 commits into
mozilla:masterfrom
timvandermeij:updates
Oct 1, 2022
Merged

Update dependencies and translations to the most recent versions#15508
timvandermeij merged 3 commits into
mozilla:masterfrom
timvandermeij:updates

Conversation

@timvandermeij
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij commented Sep 25, 2022

The major version bumps don't seem to contain any breaking changes for us; please refer to:

@timvandermeij
Copy link
Copy Markdown
Contributor Author

/botio-linux preview

@timvandermeij
Copy link
Copy Markdown
Contributor Author

/botio test

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

In addition to existing intermittent integration-test failures, it seems that this PR introduces one new problem on both bots (see excerpt below). I'd guess that the Puppeteer update might be somehow responsible, and thus require the test(s) to be tweaked.

1) Interaction in 160F-2019.pdf must check that first text field has focus
  Message:
�[31m    In firefox: Expected null to equal '401R'.�[0m
  Stack:
        at <Jasmine>
        at C:\pdfjs\botio-files-pdfjs\private\f58403b5abb3898\test\integration\scripting_spec.js:60:55
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async Promise.all (index 0)

@timvandermeij
Copy link
Copy Markdown
Contributor Author

I'll have a look at that. Sadly the integration tests are quite flaky lately :-/

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

It might be too simplistic, and possibly not robust enough, but would it work if we simply delayed trying to find the active element a little bit? Basically change

const id = await page.evaluate(() => {
const element = window.document.activeElement;
return element.getAttribute("data-element-id");
});
to something like:

const id = await page.evaluate(async () => {
  await new Promise(resolve => setTimeout(resolve, 0));

  const element = window.document.activeElement; 
  return element.getAttribute("data-element-id");
}); 

…" scripting test

This commit fixes the "Expected null to equal '401R'" errors that
surfaced after the Puppeteer 18 upgrade. Note that even before that
this would have been an improvement because it takes some time between
scripting being reported ready (i.e., triggering the execution of any
OpenActions) and those OpenActions actually completing execution, so
it's only safe to check which element is focused if we know an element
actually became focused.
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@mozilla mozilla deleted a comment from pdfjsbot Oct 1, 2022
@timvandermeij
Copy link
Copy Markdown
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8314cac3ef26baf/output.txt

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8314cac3ef26baf/output.txt

Total script time: 2.12 mins

Published

@timvandermeij
Copy link
Copy Markdown
Contributor Author

/botio test

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/36a84201351e1c1/output.txt

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/112158bea6e9363/output.txt

Copy link
Copy Markdown
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/112158bea6e9363/output.txt

Total script time: 26.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/112158bea6e9363/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 1, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/36a84201351e1c1/output.txt

Total script time: 29.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/36a84201351e1c1/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 284634f into mozilla:master Oct 1, 2022
@timvandermeij timvandermeij deleted the updates branch October 1, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants