Skip to content

Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263, #15573)#15574

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
calixteman:bug1795263
Oct 14, 2022
Merged

Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263, #15573)#15574
Snuffleupagus merged 1 commit into
mozilla:masterfrom
calixteman:bug1795263

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Oct 14, 2022

No description provided.

@calixteman calixteman changed the title Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263, #15573) Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263) Oct 14, 2022
@calixteman calixteman changed the title Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263) Use all the current transform as key when caching some image for masks used with pattern fill (bug 1795263, #15573) Oct 14, 2022
@calixteman calixteman linked an issue Oct 14, 2022 that may be closed by this pull request
Strange looking page #15573
Closed
@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Oct 14, 2022

Given how slow and memory-intensive rendering that document is, would it be feasible to create a reduced test-case instead?
Looking at how it renders, maybe just truncating the /Contents stream at some suitable point could work here?

@willkg willkg mentioned this pull request Oct 14, 2022
Open
@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Oct 14, 2022

/botio test

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 14, 2022

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/68a1240e12166b7/output.txt

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 14, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/68a1240e12166b7/output.txt

Total script time: 25.16 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/68a1240e12166b7/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 9f5fd07 into mozilla:master Oct 14, 2022
@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Oct 14, 2022

/botio makeref

@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 14, 2022

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5ac7916f4ec0888/output.txt

@calixteman calixteman deleted the bug1795263 branch October 14, 2022 13:31
@pdfjsbot
Copy link
Copy Markdown

pdfjsbot commented Oct 14, 2022

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5ac7916f4ec0888/output.txt

Total script time: 21.81 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij removed the request for review from Snuffleupagus October 15, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strange looking page

3 participants

@calixteman @Snuffleupagus @pdfjsbot