Remove the PdfManager.onLoadedStream method (PR 15616 follow-up)#15641
Merged
timvandermeij merged 1 commit intoOct 29, 2022
Merged
Conversation
After the clean-up in PR 15616, the `PdfManager.onLoadedStream` method now only has a single call-site. Hence why this patch suggests that we remove this method and replace it with an *optional* parameter in `PdfManager.requestLoadedStream` instead. By making the new behaviour opt-in, we'll thus not change any existing call-site.
Collaborator
Author
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0884a7c1cd3c1d9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d5ff622dd85bdc2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0884a7c1cd3c1d9/output.txt Total script time: 25.92 mins
Image differences available at: http://54.241.84.105:8877/0884a7c1cd3c1d9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d5ff622dd85bdc2/output.txt Total script time: 31.29 mins
Image differences available at: http://54.193.163.58:8877/d5ff622dd85bdc2/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 29, 2022
Contributor
|
Thanks for the cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the clean-up in PR #15616, the
PdfManager.onLoadedStreammethod now only has a single call-site.Hence why this patch suggests that we remove this method and replace it with an optional parameter in
PdfManager.requestLoadedStreaminstead. By making the new behaviour opt-in, we'll thus not change any existing call-site.