Skip to content

Comments

Remove unused CanvasGraphics properties (PR 700 follow-up)#20682

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:CanvasGraphics-rm-unused-props
Feb 17, 2026
Merged

Remove unused CanvasGraphics properties (PR 700 follow-up)#20682
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:CanvasGraphics-rm-unused-props

Conversation

@Snuffleupagus
Copy link
Collaborator

These are probably a copy-and-paste mistake, since they appear to have been unused already in PR #700 all the way back in 2011.

These are probably a copy-and-paste mistake, since they appear to have been unused already in PR 700 all the way back in 2011.
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Nice find!

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/091334d0e9a871e/output.txt

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.68%. Comparing base (cfc93e2) to head (336cda0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20682      +/-   ##
==========================================
- Coverage   62.72%   62.68%   -0.04%     
==========================================
  Files         169      169              
  Lines      119618   119616       -2     
==========================================
- Hits        75029    74981      -48     
- Misses      44589    44635      +46     
Flag Coverage Δ
unittestcli 62.68% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/091334d0e9a871e/output.txt

Total script time: 41.63 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/091334d0e9a871e/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 3a32ca7 into mozilla:master Feb 17, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the CanvasGraphics-rm-unused-props branch February 17, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants