Skip to content

Comments

Remove unnecessary Map.prototype.entries() usage#20691

Merged
calixteman merged 1 commit intomozilla:masterfrom
Snuffleupagus:rm-unnecessary-Map-entries
Feb 20, 2026
Merged

Remove unnecessary Map.prototype.entries() usage#20691
calixteman merged 1 commit intomozilla:masterfrom
Snuffleupagus:rm-unnecessary-Map-entries

Conversation

@Snuffleupagus
Copy link
Collaborator

A Map instance can be iterated directly with a for...of loop, hence using its entries method is not actually necessary.

A `Map` instance can be iterated directly with a `for...of` loop, hence using its `entries` method is not actually necessary.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8b03d210b77fd5f/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.61%. Comparing base (74ab1a9) to head (374f524).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/core/default_appearance.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20691      +/-   ##
==========================================
- Coverage   62.66%   62.61%   -0.05%     
==========================================
  Files         169      169              
  Lines      119865   119865              
==========================================
- Hits        75111    75059      -52     
- Misses      44754    44806      +52     
Flag Coverage Δ
unittestcli 62.61% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8b03d210b77fd5f/output.txt

Total script time: 42.88 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/8b03d210b77fd5f/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit a5c62b7 into mozilla:master Feb 20, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-unnecessary-Map-entries branch February 20, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants