Move the PagesMapper class into its own file#20848
Merged
calixteman merged 1 commit intomozilla:masterfrom Mar 12, 2026
Merged
Conversation
The `PagesMapper` class currently makes up one third of the `src/display/display_utils.js` file size, and since its introduction it's grown (a fair bit) in size. Note that the intention with files such as `src/display/display_utils.js` was to have somewhere to place functionality too small/simple to deserve its own file.
Snuffleupagus
force-pushed
the
mv-PagesMapper
branch
from
32b885e to
9aa1ce8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20848 +/- ##
==========================================
+ Coverage 62.54% 62.57% +0.02%
==========================================
Files 170 171 +1
Lines 121156 121172 +16
==========================================
+ Hits 75780 75824 +44
+ Misses 45376 45348 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/botio-linux integrationtest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/619f7a35632d560/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/619f7a35632d560/output.txt Total script time: 24.55 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PagesMapperclass currently makes up one third of thesrc/display/display_utils.jsfile size, and since its introduction it's grown (a fair bit) in size.Note that the intention with files such as
src/display/display_utils.jswas to have somewhere to place functionality too small/simple to deserve its own file.