Check for having Ref before adding them in a RefSet (bug 2023106)

[calixteman]

No description provided.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f8c598f887f28bb/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/5ec807c58ac4fba/output.txt

[codecov-commenter]

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.51%. Comparing base (b7698d6) to head (0fca64f).
⚠️ Report is 36 commits behind head on master.

Files with missing lines	Patch %	Lines
src/core/editor/pdf_editor.js	0.00%	5 Missing ⚠️
src/core/primitives.js	71.42%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20862      +/-   ##
==========================================
- Coverage   62.55%   62.51%   -0.04%     
==========================================
  Files         171      173       +2     
  Lines      121171   121259      +88     
==========================================
+ Hits        75795    75805      +10     
- Misses      45376    45454      +78     

Flag	Coverage Δ
fonttest	7.66% <0.00%> (?)
unittestcli	62.48% <67.85%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/f8c598f887f28bb/output.txt

Total script time: 44.72 mins

• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/f8c598f887f28bb/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/5ec807c58ac4fba/output.txt

Total script time: 70.49 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/5ec807c58ac4fba/reftest-analyzer.html#web=eq.log

[timvandermeij]

r=me, with the comment addressed and passing unit tests. Thanks!

[calixteman]

/botio unittest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5ccded3e631f50d/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8b69bf009c2faea/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/5ccded3e631f50d/output.txt

Total script time: 2.59 mins

• Unit Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/8b69bf009c2faea/output.txt

Total script time: 5.90 mins

• Unit Tests: Passed