Skip to content

Remove the xfatest command#20882

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij:remove-xfatest
Mar 21, 2026
Merged

Remove the xfatest command#20882
timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij:remove-xfatest

Conversation

@timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Mar 15, 2026

The XFA development work has been completed, with mostly regular maintance/bugfixing remaining, so while this special-casing for the tests made sense at the time we should now be able to remove it (see also #11851 (comment)).

Fixes a part of #11851.
Related to mozilla/botio-files-pdfjs#47.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.73%. Comparing base (ab228da) to head (f514198).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20882      +/-   ##
==========================================
+ Coverage   62.72%   62.73%   +0.01%     
==========================================
  Files         173      173              
  Lines      121500   121500              
==========================================
+ Hits        76205    76225      +20     
+ Misses      45295    45275      -20     
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.71% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij force-pushed the remove-xfatest branch 3 times, most recently from 23dd9ea to 6e7d10b Compare March 15, 2026 19:42
@timvandermeij
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2a57013dcb8e707/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b1a71708ac8dde5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/b1a71708ac8dde5/output.txt

Total script time: 18.65 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/2a57013dcb8e707/output.txt

Total script time: 25.60 mins

  • Regression tests: Passed

The XFA development work has been completed, with mostly regular
maintance/bugfixing remaining, so while this special-casing for the
tests made sense at the time we should now be able to remove it (see also
mozilla#11851 (comment)).
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij timvandermeij merged commit 5cb8f22 into mozilla:master Mar 21, 2026
15 checks passed
@timvandermeij timvandermeij deleted the remove-xfatest branch March 21, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants