Implement Gouraud-based shading using WebGPU.#20885
Merged
calixteman merged 1 commit intomozilla:masterfrom Mar 21, 2026
Merged
Implement Gouraud-based shading using WebGPU.#20885calixteman merged 1 commit intomozilla:masterfrom
calixteman merged 1 commit intomozilla:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20885 +/- ##
==========================================
- Coverage 62.72% 62.62% -0.10%
==========================================
Files 173 174 +1
Lines 121500 121930 +430
==========================================
+ Hits 76205 76353 +148
- Misses 45295 45577 +282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
And FYI, I've in mind to implement the function-based shading, when it's possible, in using WebGPU api. |
Collaborator
|
A couple of quick observations/questions:
|
Contributor
|
/botio-linux preview |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/313b63316afb1e9/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/313b63316afb1e9/output.txt Total script time: 1.93 mins Published |
timvandermeij
approved these changes
Mar 19, 2026
Contributor
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comment addressed. Let's see how this goes; thanks!
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
approved these changes
Mar 21, 2026
Snuffleupagus
approved these changes
Mar 21, 2026
Collaborator
Snuffleupagus
left a comment
Snuffleupagus
left a comment
There was a problem hiding this comment.
r=me, with comment addressed.
The WebGPU feature hasn't been released yet but it's interesting to see how we can use it in order to speed up the rendering of some objects. This patch allows to render mesh patterns using WebGPU. I didn't see any significant performance improvement on my machine (mac M2) but it may be different on other platforms.
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebGPU feature hasn't been released yet but it's interesting to see how we can use it in order to speed up the rendering of some objects.
This patch allows to render mesh patterns using WebGPU.
I didn't see any significant performance improvement on my machine (mac M2) but it may be different on other platforms.