Don't throw when a mesh shading is degenerated#20897
Don't throw when a mesh shading is degenerated#20897timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
The problem of throwing an error is that it removes an operation from drawing list which can cause a rendering issue.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3489b8823f349c0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/150ccaf19e36b05/output.txt |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20897 +/- ##
==========================================
+ Coverage 62.56% 62.58% +0.01%
==========================================
Files 173 173
Lines 121255 121252 -3
==========================================
+ Hits 75869 75880 +11
+ Misses 45386 45372 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/150ccaf19e36b05/output.txt Total script time: 45.10 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3489b8823f349c0/output.txt Total script time: 70.43 mins
|
|
Thank you for improving this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/7534997e79ebc8b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/9a8a8d74f0580ca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7534997e79ebc8b/output.txt Total script time: 18.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9a8a8d74f0580ca/output.txt Total script time: 24.94 mins
|
The problem of throwing an error is that it removes an operation from drawing list which can cause a rendering issue.