Skip to content

Don't throw when a mesh shading is degenerated#20897

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:empty_shading
Mar 17, 2026
Merged

Don't throw when a mesh shading is degenerated#20897
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:empty_shading

Conversation

@calixteman
Copy link
Contributor

The problem of throwing an error is that it removes an operation from drawing list which can cause a rendering issue.

The problem of throwing an error is that it removes an operation
from drawing list which can cause a rendering issue.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3489b8823f349c0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/150ccaf19e36b05/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (394727a) to head (085ab36).

Files with missing lines Patch % Lines
src/display/pattern_helper.js 0.00% 14 Missing ⚠️
src/core/pattern.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20897      +/-   ##
==========================================
+ Coverage   62.56%   62.58%   +0.01%     
==========================================
  Files         173      173              
  Lines      121255   121252       -3     
==========================================
+ Hits        75869    75880      +11     
+ Misses      45386    45372      -14     
Flag Coverage Δ
fonttest 7.66% <ø> (?)
unittestcli 62.55% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/150ccaf19e36b05/output.txt

Total script time: 45.10 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/3489b8823f349c0/output.txt

Total script time: 70.43 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 83f06b4 into mozilla:master Mar 17, 2026
18 of 19 checks passed
@timvandermeij
Copy link
Contributor

Thank you for improving this!

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7534997e79ebc8b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9a8a8d74f0580ca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7534997e79ebc8b/output.txt

Total script time: 18.61 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9a8a8d74f0580ca/output.txt

Total script time: 24.94 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants