Skip to content

Remove some useless operations when getting the text content#20904

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:rm_useless_op_gettextcontent
Mar 17, 2026
Merged

Remove some useless operations when getting the text content#20904
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:rm_useless_op_gettextcontent

Conversation

@calixteman
Copy link
Contributor

The removed code has been added in #20624 and it's useless since these operations (i.e. save/restore) are already handled in preprocessor.read.

The removed code has been added in mozilla#20624 and it's useless since these
operations (i.e. save/restore) are already handled in preprocessor.read.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b6d6c54bdf75c66/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/41ce2c6fcefc864/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.55%. Comparing base (1f94023) to head (fd1fea5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20904      +/-   ##
==========================================
- Coverage   62.57%   62.55%   -0.03%     
==========================================
  Files         173      173              
  Lines      121258   121255       -3     
==========================================
- Hits        75878    75851      -27     
- Misses      45380    45404      +24     
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.52% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/b6d6c54bdf75c66/output.txt

Total script time: 45.33 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/41ce2c6fcefc864/output.txt

Total script time: 73.15 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit feea0e2 into mozilla:master Mar 17, 2026
15 checks passed
@timvandermeij
Copy link
Contributor

Nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants