Skip to content

[Debugger] Allow debugging page-rendering from the /Ref, in addition to the page number#20936

Merged
calixteman merged 1 commit intomozilla:masterfrom
Snuffleupagus:debugger-getPageIndex
Mar 21, 2026
Merged

[Debugger] Allow debugging page-rendering from the /Ref, in addition to the page number#20936
calixteman merged 1 commit intomozilla:masterfrom
Snuffleupagus:debugger-getPageIndex

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Mar 21, 2026

Currently it's only possible to trigger page-render debugging through the page number, but when looking at the /Pages tree it's often not immediately obvious what the page number actually is.
However, the /Ref of the page is directly available and it's thus handy to be able to use that one instead to enable page-render debugging.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.67%. Comparing base (e577141) to head (4c05044).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20936      +/-   ##
==========================================
- Coverage   62.68%   62.67%   -0.01%     
==========================================
  Files         173      173              
  Lines      121502   121502              
==========================================
- Hits        76168    76157      -11     
- Misses      45334    45345      +11     
Flag Coverage Δ
fonttest ?
unittestcli 62.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus marked this pull request as draft March 21, 2026 10:57
…to the pageNumber

Currently it's only possible to trigger page-render debugging through the page number, but when looking at the /Pages tree it's often not immediately obvious what the page number actually is.
However, the /Ref of the page is directly available and it's thus handy to be able to use that one instead to enable page-render debugging.
@Snuffleupagus Snuffleupagus force-pushed the debugger-getPageIndex branch from b2650f1 to 4c05044 Compare March 21, 2026 11:06
@Snuffleupagus Snuffleupagus marked this pull request as ready for review March 21, 2026 11:07
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit b6c9b12 into mozilla:master Mar 21, 2026
13 checks passed
@Snuffleupagus Snuffleupagus deleted the debugger-getPageIndex branch March 21, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants