Remove readUint32 usage from the isTrueTypeFile function#21078
Remove readUint32 usage from the isTrueTypeFile function#21078Snuffleupagus merged 2 commits intomozilla:masterfrom
readUint32 usage from the isTrueTypeFile function#21078Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21078 +/- ##
==========================================
- Coverage 63.34% 63.31% -0.04%
==========================================
Files 177 177
Lines 124747 124719 -28
==========================================
- Hits 79023 78965 -58
- Misses 45724 45754 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me, with passing tests. Thanks!
This is the only `readUint32` usage in the `src/core/fonts.js` file, and it can be trivially replaced with a string comparison.
After recent patches, that added more `DataView` usage, these helper functions are now unused.
2e8a07a to
2e5ab9c
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b10f114ff3688dd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/18a71389341762f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b10f114ff3688dd/output.txt Total script time: 2.84 mins
|
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/0d5a9fdda34c35f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/18a71389341762f/output.txt Total script time: 6.86 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0d5a9fdda34c35f/output.txt Total script time: 18.36 mins
|
This is the only
readUint32usage in thesrc/core/fonts.jsfile, and it can be trivially replaced with a string comparison.