Add an abstract readBlock method in the DecodeStream class#21190
Conversation
This avoids having to "duplicate" dummy `readBlock` methods in a couple of image-stream classes. Also, move a few `DecodeStream` field definitions to (ever so slightly) shorten the code.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21190 +/- ##
==========================================
+ Coverage 63.94% 63.97% +0.02%
==========================================
Files 213 213
Lines 134597 134595 -2
==========================================
+ Hits 86064 86103 +39
+ Misses 48533 48492 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e04c21e125bd951/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d21ca3e6a285da5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e04c21e125bd951/output.txt Total script time: 18.48 mins
Image differences available at: http://54.241.84.105:8877/e04c21e125bd951/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d21ca3e6a285da5/output.txt Total script time: 24.62 mins
Image differences available at: http://54.193.163.58:8877/d21ca3e6a285da5/reftest-analyzer.html#web=eq.log |
This avoids having to "duplicate" dummy
readBlockmethods in a couple of image-stream classes.Also, move a few
DecodeStreamfield definitions to (ever so slightly) shorten the code.