Skip to content

Shorten how intersectors are added to the grid in the Intersector constructor#21200

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Intersector-grid-push
Apr 30, 2026
Merged

Shorten how intersectors are added to the grid in the Intersector constructor#21200
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:Intersector-grid-push

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Thanks to modern JavaScript features this code can be simplified a tiny bit.

…onstructor

Thanks to modern JavaScript features this code can be simplified a tiny bit.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.95%. Comparing base (d92db13) to head (4a5c455).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21200      +/-   ##
==========================================
+ Coverage   55.71%   55.95%   +0.24%     
==========================================
  Files         209      218       +9     
  Lines       57398    59063    +1665     
==========================================
+ Hits        31977    33048    +1071     
- Misses      25421    26015     +594     
Flag Coverage Δ
fonttest 8.66% <ø> (?)
unittest 55.06% <100.00%> (?)
unittestcli 55.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

@Snuffleupagus Snuffleupagus merged commit adf07ea into mozilla:master Apr 30, 2026
22 checks passed
@Snuffleupagus Snuffleupagus deleted the Intersector-grid-push branch April 30, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants