Remove obsolete pdfBug: true flag in the image caching unit test#21203
Merged
timvandermeij merged 1 commit intoApr 30, 2026
Merged
Conversation
In a previous commit the time-based checks, which were based on statistics provided by the `pdfBug: true` flag, got replaced by test-only property checks that don't use said statistics anymore. Fixes b01eeaf.
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21203 +/- ##
=======================================
Coverage 55.93% 55.94%
=======================================
Files 218 218
Lines 59059 59059
=======================================
+ Hits 33037 33041 +4
+ Misses 26022 26018 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous commit the time-based checks, which were based on statistics provided by the
pdfBug: trueflag, got replaced by test-only property checks that don't use said statistics anymore.Fixes b01eeaf.