Remove the unused raw field from the CFFCharset class#21216
Conversation
This was necessary before charset compilation was implemented, however that's been supported for many years and this is just dead code now. - PR 9340, back in 2018, stopped using the `raw` field. - PR 10591, back in 2019, implemented proper charset compilation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21216 +/- ##
==========================================
- Coverage 55.96% 55.95% -0.02%
==========================================
Files 218 218
Lines 59037 59033 -4
==========================================
- Hits 33040 33029 -11
- Misses 25997 26004 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fda4ef9eac7f876/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cf7510b95ec15da/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/cf7510b95ec15da/output.txt Total script time: 18.14 mins
Image differences available at: http://54.241.84.105:8877/cf7510b95ec15da/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fda4ef9eac7f876/output.txt Total script time: 24.47 mins
Image differences available at: http://54.193.163.58:8877/fda4ef9eac7f876/reftest-analyzer.html#web=eq.log |
|
Nice find! |
This was necessary before charset compilation was implemented, however that's been supported for many years and this is just dead code now.
rawfield.