Skip to content

Remove the unused raw field from the CFFCharset class#21216

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:CFFCharset-rm-raw
May 3, 2026
Merged

Remove the unused raw field from the CFFCharset class#21216
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:CFFCharset-rm-raw

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

This was necessary before charset compilation was implemented, however that's been supported for many years and this is just dead code now.

This was necessary before charset compilation was implemented, however that's been supported for many years and this is just dead code now.
 - PR 9340, back in 2018, stopped using the `raw` field.
 - PR 10591, back in 2019, implemented proper charset compilation.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.95%. Comparing base (f54f4b6) to head (53fd896).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21216      +/-   ##
==========================================
- Coverage   55.96%   55.95%   -0.02%     
==========================================
  Files         218      218              
  Lines       59037    59033       -4     
==========================================
- Hits        33040    33029      -11     
- Misses      25997    26004       +7     
Flag Coverage Δ
fonttest 8.67% <0.00%> (+<0.01%) ⬆️
unittest 55.20% <100.00%> (-0.02%) ⬇️
unittestcli 55.70% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fda4ef9eac7f876/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cf7510b95ec15da/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/cf7510b95ec15da/output.txt

Total script time: 18.14 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/cf7510b95ec15da/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/fda4ef9eac7f876/output.txt

Total script time: 24.47 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/fda4ef9eac7f876/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit a55cec4 into mozilla:master May 3, 2026
21 of 22 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

Nice find!

@Snuffleupagus Snuffleupagus deleted the CFFCharset-rm-raw branch May 3, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants