Skip to content

Replace TrueTypeTableBuilder and CompilerOutput with a single class#21220

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:DataBuilder
May 5, 2026
Merged

Replace TrueTypeTableBuilder and CompilerOutput with a single class#21220
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:DataBuilder

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Given that both of these classes are so similar, let's replace them with a single DataBuilder class instead to reduce unnecessary code-duplication.

Given that both of these classes are so similar, let's replace them with a single `DataBuilder` class instead to reduce unnecessary code-duplication.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2026

Codecov Report

❌ Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.94%. Comparing base (a55cec4) to head (ac6a923).

Files with missing lines Patch % Lines
src/core/data_builder.js 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21220      +/-   ##
==========================================
- Coverage   55.97%   55.94%   -0.03%     
==========================================
  Files         218      219       +1     
  Lines       59033    59017      -16     
==========================================
- Hits        33041    33016      -25     
- Misses      25992    26001       +9     
Flag Coverage Δ
fonttest 8.68% <57.14%> (+<0.01%) ⬆️
unittest 55.20% <98.70%> (-0.03%) ⬇️
unittestcli 55.69% <98.70%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4b28bf7826497cd/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/60b828d48e3e7af/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/60b828d48e3e7af/output.txt

Total script time: 18.04 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/60b828d48e3e7af/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4b28bf7826497cd/output.txt

Total script time: 24.37 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/4b28bf7826497cd/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus requested a review from calixteman May 5, 2026 09:21
Comment thread src/core/data_builder.js
Comment thread src/core/data_builder.js
Copy link
Copy Markdown
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus requested a review from calixteman May 5, 2026 10:41
@Snuffleupagus Snuffleupagus merged commit e8d3d19 into mozilla:master May 5, 2026
25 of 26 checks passed
@Snuffleupagus Snuffleupagus deleted the DataBuilder branch May 5, 2026 11:07
@timvandermeij timvandermeij removed the request for review from calixteman May 5, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants