Replace TrueTypeTableBuilder and CompilerOutput with a single class#21220
Replace TrueTypeTableBuilder and CompilerOutput with a single class#21220Snuffleupagus merged 1 commit intomozilla:masterfrom
TrueTypeTableBuilder and CompilerOutput with a single class#21220Conversation
Given that both of these classes are so similar, let's replace them with a single `DataBuilder` class instead to reduce unnecessary code-duplication.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21220 +/- ##
==========================================
- Coverage 55.97% 55.94% -0.03%
==========================================
Files 218 219 +1
Lines 59033 59017 -16
==========================================
- Hits 33041 33016 -25
- Misses 25992 26001 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4b28bf7826497cd/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/60b828d48e3e7af/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/60b828d48e3e7af/output.txt Total script time: 18.04 mins
Image differences available at: http://54.241.84.105:8877/60b828d48e3e7af/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4b28bf7826497cd/output.txt Total script time: 24.37 mins
Image differences available at: http://54.193.163.58:8877/4b28bf7826497cd/reftest-analyzer.html#web=eq.log |
Given that both of these classes are so similar, let's replace them with a single
DataBuilderclass instead to reduce unnecessary code-duplication.