Include the external/ folder in the coverage report for gulp unittestcli#21226
Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom May 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21226 +/- ##
==========================================
- Coverage 55.92% 55.92% -0.01%
==========================================
Files 220 220
Lines 58990 58990
==========================================
- Hits 32993 32992 -1
- Misses 25997 25998 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a2085a5 to
ddd37b6
Compare
Contributor
|
We don't use c8 anymore so you can remove the json. |
…estcli` Given that the (browser) `gulp unittest` coverage includes the `external/` folder, it seems reasonable to include that folder in the coverage report when running unit-tests in Node.js as well.
ddd37b6 to
d33d9fc
Compare
timvandermeij
approved these changes
May 5, 2026
Contributor
|
Looks good to me like this; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the (browser)
gulp unittestcoverage includes theexternal/folder, it seems reasonable to include that folder in the coverage report when running unit-tests in Node.js as well.