Skip to content

Fall back to pixel-buffer SMask filtering when ctx.filter is unavailable#21236

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:pixel_fallback_smask
May 10, 2026
Merged

Fall back to pixel-buffer SMask filtering when ctx.filter is unavailable#21236
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:pixel_fallback_smask

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

For now OffscreenCanvas in worker threads doesn't support ctx.filter, so we need to fall back to a more expensive pixel-buffer SMask filtering in that case.
As a side effect, this also allows to support correctly smask in Safari.

For now OffscreenCanvas in worker threads doesn't support ctx.filter,
so we need to fall back to a more expensive pixel-buffer SMask filtering in that case.
As a side effect, this also allows to support correctly smask in Safari.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.03%. Comparing base (a328294) to head (b823271).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/display/canvas.js 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21236      +/-   ##
==========================================
- Coverage   56.04%   56.03%   -0.01%     
==========================================
  Files         220      220              
  Lines       58973    58986      +13     
==========================================
+ Hits        33053    33055       +2     
- Misses      25920    25931      +11     
Flag Coverage Δ
fonttest 8.65% <ø> (ø)
unittest 55.31% <0.00%> (-0.01%) ⬇️
unittestcli 54.56% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

@timvandermeij timvandermeij merged commit 559e2f2 into mozilla:master May 10, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants