Fall back to pixel-buffer SMask filtering when ctx.filter is unavailable#21236
Merged
Merged
Conversation
For now OffscreenCanvas in worker threads doesn't support ctx.filter, so we need to fall back to a more expensive pixel-buffer SMask filtering in that case. As a side effect, this also allows to support correctly smask in Safari.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21236 +/- ##
==========================================
- Coverage 56.04% 56.03% -0.01%
==========================================
Files 220 220
Lines 58973 58986 +13
==========================================
+ Hits 33053 33055 +2
- Misses 25920 25931 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now OffscreenCanvas in worker threads doesn't support ctx.filter, so we need to fall back to a more expensive pixel-buffer SMask filtering in that case.
As a side effect, this also allows to support correctly smask in Safari.