Make the PDFDataRangeTransport streaming unit-tests faster#21238
Merged
timvandermeij merged 1 commit intoMay 10, 2026
Merged
Conversation
The delay between chunks when testing streaming is necessary to avoid the entire PDF document arriving all at once, since that would render those unit-tests somewhat pointless. However, the delay is unnecessarily large which causes these unit-tests to be slower than necessary. Also, update the range unit-tests to check the expected number of fetches *exactly* since those values are not supposed to vary.
d4798ad to
1592124
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21238 +/- ##
==========================================
+ Coverage 54.57% 55.99% +1.42%
==========================================
Files 216 220 +4
Lines 58860 58964 +104
==========================================
+ Hits 32120 33016 +896
+ Misses 26740 25948 -792
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
May 10, 2026
Contributor
|
Nice find; thank you for speeding up the tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delay between chunks when testing streaming is necessary to avoid the entire PDF document arriving all at once, since that would render those unit-tests somewhat pointless.
However, the delay is unnecessarily large which causes these unit-tests to be slower than necessary.
Also, update the range unit-tests to check the expected number of fetches exactly since those values are not supposed to vary.
Note: This reduces the runtime of the
should fetch document info and page using only streamingunit-test by1200ms.